From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D074FCA9EA0 for ; Fri, 18 Oct 2019 09:41:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 93B3121897 for ; Fri, 18 Oct 2019 09:41:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KBv/GTlW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93B3121897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 45F2A8E001A; Fri, 18 Oct 2019 05:41:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 410E68E0003; Fri, 18 Oct 2019 05:41:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7CE8E001A; Fri, 18 Oct 2019 05:41:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id 0CEB18E0003 for ; Fri, 18 Oct 2019 05:41:21 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 86193183432D3 for ; Fri, 18 Oct 2019 09:41:20 +0000 (UTC) X-FDA: 76056412320.10.jail48_62f3c309efa22 X-HE-Tag: jail48_62f3c309efa22 X-Filterd-Recvd-Size: 4165 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Oct 2019 09:41:19 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id b20so5530860ljj.5 for ; Fri, 18 Oct 2019 02:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FaqhYpk8/vEXz6AyAyq6XdJfdwEpVbnl8qtLLXSCjzU=; b=KBv/GTlWHcfp48EqhdfNng4cY0v8E8BlIOjghU9vrW1AIMRJJslFn/IUm3tuZudMMm ntgbzQo+rBkaTyRuiUjQTN18gJF8PtMG8AOQwuLopRfrZX4ERIHIYRvey+kPwlJpJAry xuO4t1yim1gmKAgLZmGuPwwRvMMjq8U2SJ15AJQzYvV4vJ9vE77xngJlKWMwDGeR7vsE uQtEWfhvHAVDsh6eGnjTSdlZktlQYub0FodHqeluJ4Yr51VxYi/lZPb9iotNENOhrnCA uJBYxOx7vg7loiTptivSzIPO9iFLzzjS93DPEY6zuztGba4wXvdJ6QAk/cCbjkMNj0rq GkoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FaqhYpk8/vEXz6AyAyq6XdJfdwEpVbnl8qtLLXSCjzU=; b=e1XuYreJ8k/WLXsdHrHbb/CLA4tM3DxKw1tWdw5j5nMtRSGIERdzSWXfF4YTt7njQW bOYl4FjiqYZqkJdMXCg/Dw+iusZWkNXUJszGaQlmPfUuurltg8bzo5pnln2jHh8HqXn/ Zwwz7/jizUy7DfXTM+FNA8PFxyVrZloAVcF4J5bcHV+2+E0maj0UKj7YLgV6yTa/YXJ/ dzoJxBgSXo74fj39+eJIUB3GRKPNciUWzrcoZX9dyBX8RNEAiLn/1V5L2dw8gIXKRq1p QnQfOIqhEIZD6469+aPq3JZpJcMDAP+16e7O5wHyQOWEuP0fAgJWeWwUWObIM5BHRrmR 3OUQ== X-Gm-Message-State: APjAAAXOOUZ0WwNYjpxcEfYEhWl0OOiS0yQ28XMse+xTJqYyN2tsYdAi I/yjHXMWsAUgySYD6YzB2qo= X-Google-Smtp-Source: APXvYqycdQ7AhAX+shpXYAMhzOz05krOqyr45JSNDo9nzzzaNpIEsoiAOmL24cPaVOexJIaU9gErHw== X-Received: by 2002:a2e:2943:: with SMTP id u64mr5616305lje.241.1571391678535; Fri, 18 Oct 2019 02:41:18 -0700 (PDT) Received: from pc636 ([37.139.158.167]) by smtp.gmail.com with ESMTPSA id a27sm3395039lfj.48.2019.10.18.02.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 02:41:17 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 18 Oct 2019 11:41:15 +0200 To: Michal Hocko Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , Daniel Wagner , Sebastian Andrzej Siewior , Thomas Gleixner , linux-mm@kvack.org, LKML , Peter Zijlstra , Hillf Danton , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH v3 3/3] mm/vmalloc: add more comments to the adjust_va_to_fit_type() Message-ID: <20191018094115.GC8744@pc636> References: <20191016095438.12391-1-urezki@gmail.com> <20191016095438.12391-3-urezki@gmail.com> <20191016110722.GU317@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191016110722.GU317@dhcp22.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 16, 2019 at 01:07:22PM +0200, Michal Hocko wrote: > On Wed 16-10-19 11:54:38, Uladzislau Rezki (Sony) wrote: > > When fit type is NE_FIT_TYPE there is a need in one extra object. > > Usually the "ne_fit_preload_node" per-CPU variable has it and > > there is no need in GFP_NOWAIT allocation, but there are exceptions. > > > > This commit just adds more explanations, as a result giving > > answers on questions like when it can occur, how often, under > > which conditions and what happens if GFP_NOWAIT gets failed. > > > > Signed-off-by: Uladzislau Rezki (Sony) > > Acked-by: Michal Hocko > Thanks! -- Vlad Rezki