From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2889ECE58E for ; Thu, 17 Oct 2019 11:45:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 578752089C for ; Thu, 17 Oct 2019 11:45:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="gb5sgjEA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 578752089C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 99BED8E0005; Thu, 17 Oct 2019 07:45:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94BBC8E0003; Thu, 17 Oct 2019 07:45:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 863658E0005; Thu, 17 Oct 2019 07:45:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 622A08E0003 for ; Thu, 17 Oct 2019 07:45:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id E98E15824 for ; Thu, 17 Oct 2019 11:45:02 +0000 (UTC) X-FDA: 76053095244.07.sand71_6631e88ce1453 X-HE-Tag: sand71_6631e88ce1453 X-Filterd-Recvd-Size: 3723 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Oct 2019 11:45:02 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id a22so2224327ljd.0 for ; Thu, 17 Oct 2019 04:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WP3ebuh7sgKEELQcpgEbN/gzP8uJWNJwh0VxumxieOE=; b=gb5sgjEAi5RRg8xOWG8bgXIAwcdIPyZoeUH5NAQDRATkjJCOxwIKQBjjf6D7JwCMB5 8Bh0SSO1AbugOe0Y8BBEKjW4sMQwGY46RqJcbVcSzCtTdQFEkeNENNO5x0r/Ynz5gGQt zVL4AppMZlQBZ+yYKRjNoD+1GRGoNUNlq0fCrNGGz1bF+Vurv4Z67Id5sqqufT0vY8Zn i+u2p0pLNw/H2DJ1BZ7VCyTJWYUJaZyAjc1/mzHnaXQXq/k2O6S/TUwkYmY2ZTjXtrKi Dnrf/Trfd7OQUt7HOc6zXdUKV64yL/D+AoTF7qpgQzvR7SHRAO1pKVq8RbgfjsUgrrK5 ZHJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WP3ebuh7sgKEELQcpgEbN/gzP8uJWNJwh0VxumxieOE=; b=or4gRAmhuZ/Wt56VFVjGECsyPvlat586dn/VXHcryFqfptznIkFJBjf+/ozHkIojIL VGWaw6h4GCWCnsIgPuZKdzlF5X/MdEnSEMn2MT6bpx0xLNjhx9h0R2ngPeH7xKJbGDjT /dwrwBTNoyNoH2Ry/UJ5zPjwGMG7mnGyq9gkJ6accMSS3eULrENMjIO2X/RLt2GmuP25 rbMeG9O5Jsk4GdCtiB0/cOQUBm+QA8s/4L0qyDLuNLeBmoU7aeTfVSQpfoQKs5w9Q8Nj YCiDdGHk9He08ThT1C+XXLBgM4XVzBXZzIwRQm7LO/eHw+OETtwMkV/Q4ngompYrz//r Z+CQ== X-Gm-Message-State: APjAAAU+aFpZV/8lbwaI8pElyTDQ9qBJFEGB9vZ/3kUHjWintW+4AWRO BZ7J2msBShNdXPODmsf1r21bVA== X-Google-Smtp-Source: APXvYqzTqIQzOWMja1Bd9eCdre1/gu/YFXK64B6rsBOXZvKdbkSxJTcFxkghMY2qeHv9KKobqzWAhg== X-Received: by 2002:a2e:8852:: with SMTP id z18mr2329179ljj.230.1571312700640; Thu, 17 Oct 2019 04:45:00 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id t24sm900286ljc.23.2019.10.17.04.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 04:44:59 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 975F51001A2; Thu, 17 Oct 2019 14:44:58 +0300 (+03) Date: Thu, 17 Oct 2019 14:44:58 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, keith.busch@intel.com Subject: Re: [PATCH 1/4] node: Define and export memory migration path Message-ID: <20191017114458.x4atu3vy7ogddvbm@box> References: <20191016221148.F9CCD155@viggo.jf.intel.com> <20191016221149.74AE222C@viggo.jf.intel.com> <20191017111205.krurdatuv7d4brs4@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017111205.krurdatuv7d4brs4@box> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 17, 2019 at 02:12:05PM +0300, Kirill A. Shutemov wrote: > > + spin_lock(&node_migration_lock); > > + WRITE_ONCE(node_migration[nid], TERMINAL_NODE); > > + spin_unlock(&node_migration_lock); > > + return count; > > + } > > + if (next >= MAX_NUMNODES || !node_online(next)) > > + return -EINVAL; > > What prevents offlining after the check? And what is story with memory hotplug interaction? I don't see any hooks into memory hotplug to adjust migration path on offlining. Hm? -- Kirill A. Shutemov