From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC355FA372A for ; Thu, 17 Oct 2019 08:03:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9415A21848 for ; Thu, 17 Oct 2019 08:03:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9415A21848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4274F8E0006; Thu, 17 Oct 2019 04:03:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D7408E0003; Thu, 17 Oct 2019 04:03:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 314248E0006; Thu, 17 Oct 2019 04:03:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 0E9658E0003 for ; Thu, 17 Oct 2019 04:03:27 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 6B164181AEF00 for ; Thu, 17 Oct 2019 08:03:26 +0000 (UTC) X-FDA: 76052536812.17.juice64_3b12b58bd5243 X-HE-Tag: juice64_3b12b58bd5243 X-Filterd-Recvd-Size: 2333 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Oct 2019 08:03:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2B1E5AF05; Thu, 17 Oct 2019 08:03:24 +0000 (UTC) Date: Thu, 17 Oct 2019 10:03:21 +0200 From: Oscar Salvador To: Naoya Horiguchi Cc: David Hildenbrand , Naoya Horiguchi , "linux-mm@kvack.org" , Michal Hocko , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH] mm, soft-offline: convert parameter to pfn Message-ID: <20191017080315.GA31827@linux> References: <20191016070924.GA10178@hori.linux.bs1.fc.nec.co.jp> <20191016082735.GB13770@hori.linux.bs1.fc.nec.co.jp> <20191016085359.GD13770@hori.linux.bs1.fc.nec.co.jp> <997b5b51-db71-3e27-1f84-cbaa24fa66c7@redhat.com> <20191016234706.GA5493@www9186uo.sakura.ne.jp> <20191017075018.GA10225@hori.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017075018.GA10225@hori.linux.bs1.fc.nec.co.jp> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 17, 2019 at 07:50:18AM +0000, Naoya Horiguchi wrote: > Actually I guess that !pfn_valid() never happens when called from > madvise_inject_error(), because madvise_inject_error() gets pfn via > get_user_pages_fast() which only returns valid page for valid pfn. > > And we plan to remove MF_COUNT_INCREASED by Oscar's re-design work, > so I start feeling that this patch should come on top of his tree. Hi Naoya, I am pretty much done with my testing. If you feel like, I can take the patch and add it on top of [1] , then I will do some more testing and, if nothing pops up, I will send it upstream. [1] https://github.com/leberus/linux/tree/hwpoison-v2 > > Thanks, > Naoya Horiguchi -- Oscar Salvador SUSE L3