From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C8A4FA372A for ; Wed, 16 Oct 2019 11:51:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7A1FA20854 for ; Wed, 16 Oct 2019 11:51:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A1FA20854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2D07B8E001F; Wed, 16 Oct 2019 07:51:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 281308E0001; Wed, 16 Oct 2019 07:51:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BEFE8E001F; Wed, 16 Oct 2019 07:51:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id EAC428E0001 for ; Wed, 16 Oct 2019 07:51:21 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 8BBFE2827 for ; Wed, 16 Oct 2019 11:51:21 +0000 (UTC) X-FDA: 76049482362.20.match74_63220909fef58 X-HE-Tag: match74_63220909fef58 X-Filterd-Recvd-Size: 2166 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Oct 2019 11:51:21 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E2DC7B576; Wed, 16 Oct 2019 11:51:19 +0000 (UTC) Date: Wed, 16 Oct 2019 13:51:19 +0200 From: Michal Hocko To: Anshuman Khandual Cc: David Hildenbrand , linux-mm@kvack.org, Mike Kravetz , Andrew Morton , Vlastimil Babka , David Rientjes , Andrea Arcangeli , Oscar Salvador , Mel Gorman , Mike Rapoport , Dan Williams , Pavel Tatashin , Matthew Wilcox , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm/page_alloc: Add alloc_contig_pages() Message-ID: <20191016115119.GA317@dhcp22.suse.cz> References: <1571223765-10662-1-git-send-email-anshuman.khandual@arm.com> <40b8375c-5291-b477-1519-fd7fa799a67d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 16-10-19 16:43:57, Anshuman Khandual wrote: > > > On 10/16/2019 04:39 PM, David Hildenbrand wrote: [...] > > Just to make sure, you ignored my comment regarding alignment > > although I explicitly mentioned it a second time? Thanks. > > I had asked Michal explicitly what to be included for the respin. Anyways > seems like the previous thread is active again. I am happy to incorporate > anything new getting agreed on there. Your patch is using the same alignment as the original code would do. If an explicit alignement is needed then this can be added on top, right? -- Michal Hocko SUSE Labs