From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 781A7FA372A for ; Wed, 16 Oct 2019 10:33:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5074F2168B for ; Wed, 16 Oct 2019 10:33:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5074F2168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBE2C8E000D; Wed, 16 Oct 2019 06:33:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6E548E0001; Wed, 16 Oct 2019 06:33:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83EB8E000D; Wed, 16 Oct 2019 06:33:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id 830B18E0001 for ; Wed, 16 Oct 2019 06:33:19 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 21FCD4835 for ; Wed, 16 Oct 2019 10:33:19 +0000 (UTC) X-FDA: 76049285718.25.eggs18_9155dbd700e22 X-HE-Tag: eggs18_9155dbd700e22 X-Filterd-Recvd-Size: 2028 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Oct 2019 10:33:18 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 27A56B266; Wed, 16 Oct 2019 10:33:17 +0000 (UTC) Date: Wed, 16 Oct 2019 12:33:15 +0200 From: Michal Hocko To: Anshuman Khandual Cc: linux-mm@kvack.org, Mike Kravetz , Andrew Morton , Vlastimil Babka , David Rientjes , Andrea Arcangeli , Oscar Salvador , Mel Gorman , Mike Rapoport , Dan Williams , Pavel Tatashin , Matthew Wilcox , David Hildenbrand , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use Message-ID: <20191016103315.GR317@dhcp22.suse.cz> References: <1571211293-29974-1-git-send-email-anshuman.khandual@arm.com> <20191016085839.GP317@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 16-10-19 15:58:32, Anshuman Khandual wrote: > > > On 10/16/2019 02:28 PM, Michal Hocko wrote: [...] > > After other issues mentioned by David get resolved you can add > > Just to confirm. Only the styling issues, right ? pfn_range_valid_contig(), > pfn alignment and zone scanning all remain the same like before ? Yes, if they need any special handling then let's do it in a separate patch with a proper justification. -- Michal Hocko SUSE Labs