From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04875FA372C for ; Wed, 16 Oct 2019 09:54:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC34121848 for ; Wed, 16 Oct 2019 09:54:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hh2BQR9H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC34121848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FD818E0008; Wed, 16 Oct 2019 05:54:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6372E8E0001; Wed, 16 Oct 2019 05:54:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39F8F8E0008; Wed, 16 Oct 2019 05:54:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 0B4968E0001 for ; Wed, 16 Oct 2019 05:54:52 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 95737183D71F1 for ; Wed, 16 Oct 2019 09:54:51 +0000 (UTC) X-FDA: 76049188782.15.clam72_6491c71a9b03e X-HE-Tag: clam72_6491c71a9b03e X-Filterd-Recvd-Size: 4871 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Oct 2019 09:54:51 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id r2so16896821lfn.8 for ; Wed, 16 Oct 2019 02:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8BWvlmXa5Itb4HNOlJ7mNfofmk+n7/jwhwr224X7wkA=; b=hh2BQR9H/TttXyKoEjHs8VBNq116FbnDFbRYWngV3I1sbmyuCJJ0vQH83n9YmJgHQS USutVgNbliEBrCahSr2saDHdP9vgSwJOLG8mjfs+fEW3aFx4aduW3klPJGYQsa2F3DnQ P2KzeoYK2UXDFk9PzwqjjggtmuIrxibVzQClvj8qnA9Q7L72eManT4pLUm2JFW/CvjgK eM87O72+RoLgxEDvHpa4Nn6Mxt33vFRsd/Fcc5ic0fnnZqgX5PNG/YQcBURfbDSMckxf xIDEtnk1d6jfkScKnA5gc/H63GJYsDi+B0OLWl+qIKqqsK7SFX+yLlCvDEeav2dSA1r4 c6Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8BWvlmXa5Itb4HNOlJ7mNfofmk+n7/jwhwr224X7wkA=; b=lYTahVXKu3DGM/26X6s40I+UB0E6k0XyIER9KvkqlnuS3TDX4bdM2z6uWmQshGs4Cf CwB9iZG9wD9St0RxaDYOPP/Aen3S36ADLd1rLlVUlhjbbiu7ylH3KIx2dewfh0LloheF 7fwaye3KeiwVAbCPZl+zxvcCiGxJdDvzSWgXuDuVr2CQI8YH5CAg1YINxi5cm8Y4pDSi 3vos/EolgHV9XHr7Ttw+L2YKd0rry02HJGXQmSolGKQi77hFE8DHSiqLFo4kMlhil/9L z1gi8dLsra9i5cJ0qoc3Xqwd8oGmQjEeVtB0bCwkEuOGfA9HQjWy5etiIK7aLKn4JzwM 1E1A== X-Gm-Message-State: APjAAAX7Azr3ubvrXTmz7XR6EEBzToRjeoF/ee+L66dm2Fki1s07G8UN 3STTB4wFPilORYmBt8Xj3kQ= X-Google-Smtp-Source: APXvYqyHqhSJPrwVPXwEIlMetVVFuIqlUxsmBmpW3xM6pBv558tYFejHW/wi29csutcwzsGqsNpstg== X-Received: by 2002:ac2:4c38:: with SMTP id u24mr1294786lfq.45.1571219689589; Wed, 16 Oct 2019 02:54:49 -0700 (PDT) Received: from pc636.semobile.internal ([37.139.158.167]) by smtp.gmail.com with ESMTPSA id b2sm886452lfq.27.2019.10.16.02.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 02:54:48 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: Daniel Wagner , Sebastian Andrzej Siewior , Thomas Gleixner , linux-mm@kvack.org, LKML , Peter Zijlstra , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH v3 2/3] mm/vmalloc: respect passed gfp_mask when do preloading Date: Wed, 16 Oct 2019 11:54:37 +0200 Message-Id: <20191016095438.12391-2-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191016095438.12391-1-urezki@gmail.com> References: <20191016095438.12391-1-urezki@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: alloc_vmap_area() is given a gfp_mask for the page allocator. Let's respect that mask and consider it even in the case when doing regular CPU preloading, i.e. where a context can sleep. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index b7b443bfdd92..593bf554518d 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1064,9 +1064,9 @@ static struct vmap_area *alloc_vmap_area(unsigned l= ong size, return ERR_PTR(-EBUSY); =20 might_sleep(); + gfp_mask =3D gfp_mask & GFP_RECLAIM_MASK; =20 - va =3D kmem_cache_alloc_node(vmap_area_cachep, - gfp_mask & GFP_RECLAIM_MASK, node); + va =3D kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node); if (unlikely(!va)) return ERR_PTR(-ENOMEM); =20 @@ -1074,7 +1074,7 @@ static struct vmap_area *alloc_vmap_area(unsigned l= ong size, * Only scan the relevant parts containing pointers to other objects * to avoid false negatives. */ - kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask & GFP_RECLAIM_MASK)= ; + kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask); =20 retry: /* @@ -1100,7 +1100,7 @@ static struct vmap_area *alloc_vmap_area(unsigned l= ong size, * Just proceed as it is. If needed "overflow" path * will refill the cache we allocate from. */ - pva =3D kmem_cache_alloc_node(vmap_area_cachep, GFP_KERNEL, node); + pva =3D kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node); =20 spin_lock(&vmap_area_lock); =20 --=20 2.20.1