From: Matthew Wilcox <willy@infradead.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, anshuman.khandual@arm.com,
ard.biesheuvel@linaro.org, broonie@kernel.org,
christophe.leroy@c-s.fr, dan.j.williams@intel.com,
dave.hansen@intel.com, davem@davemloft.net,
gerald.schaefer@de.ibm.com, gregkh@linuxfoundation.org,
heiko.carstens@de.ibm.com, jgg@ziepe.ca, jhogan@kernel.org,
keescook@chromium.org, kirill@shutemov.name,
linux@armlinux.org.uk, mark.rutland@arm.com,
mike.kravetz@oracle.com, mm-commits@vger.kernel.org,
mpe@ellerman.id.au, paul.burton@mips.com, paulus@samba.org,
penguin-kernel@i-love.sakura.ne.jp, peterz@infradead.org,
ralf@linux-mips.org, rppt@linux.vnet.ibm.com,
schowdary@nvidia.com, schwidefsky@de.ibm.com,
Steven.Price@arm.com, tglx@linutronix.de, vbabka@suse.cz,
vgupta@synopsys.com, yamada.masahiro@socionext.com,
linux-mm@kvack.org
Subject: Re: + mm-hugetlb-make-alloc_gigantic_page-available-for-general-use.patch added to -mm tree
Date: Mon, 14 Oct 2019 13:29:26 -0700 [thread overview]
Message-ID: <20191014202926.GZ32665@bombadil.infradead.org> (raw)
In-Reply-To: <20191014121730.GE317@dhcp22.suse.cz>
On Mon, Oct 14, 2019 at 02:17:30PM +0200, Michal Hocko wrote:
> On Fri 11-10-19 13:29:32, Andrew Morton wrote:
> > alloc_gigantic_page() implements an allocation method where it scans over
> > various zones looking for a large contiguous memory block which could not
> > have been allocated through the buddy allocator. A subsequent patch which
> > tests arch page table helpers needs such a method to allocate PUD_SIZE
> > sized memory block. In the future such methods might have other use cases
> > as well. So alloc_gigantic_page() has been split carving out actual
> > memory allocation method and made available via new
> > alloc_gigantic_page_order().
>
> You are exporting a helper used for hugetlb internally. Is this really
> what is needed? I haven't followed this patchset but don't you simply
> need a generic 1GB allocator? If yes then you should be looking at
> alloc_contig_range.
He actually doesn't need to allocate any memory at all. All he needs is
the address of a valid contiguous PUD-sized chunk of memory.
next prev parent reply other threads:[~2019-10-14 20:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191011202932.GZoUOoURm%akpm@linux-foundation.org>
2019-10-14 12:17 ` Michal Hocko
2019-10-14 12:53 ` Anshuman Khandual
2019-10-14 13:00 ` Michal Hocko
2019-10-14 13:08 ` Anshuman Khandual
2019-10-14 13:21 ` Michal Hocko
2019-10-14 16:52 ` Mike Kravetz
2019-10-15 9:57 ` Anshuman Khandual
2019-10-15 10:31 ` Michal Hocko
2019-10-15 10:34 ` Anshuman Khandual
2019-10-14 20:29 ` Matthew Wilcox [this message]
2019-10-15 9:30 ` Anshuman Khandual
2019-10-15 11:24 ` Matthew Wilcox
2019-10-15 11:36 ` Michal Hocko
2019-10-15 12:14 ` Anshuman Khandual
2019-10-16 8:55 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014202926.GZ32665@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Steven.Price@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=broonie@kernel.org \
--cc=christophe.leroy@c-s.fr \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=davem@davemloft.net \
--cc=gerald.schaefer@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jhogan@kernel.org \
--cc=keescook@chromium.org \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mm-commits@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=schowdary@nvidia.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=vgupta@synopsys.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox