From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC33C4CECE for ; Mon, 14 Oct 2019 14:51:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1CEF1217D9 for ; Mon, 14 Oct 2019 14:51:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="PPtoDEJU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CEF1217D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B2F648E0006; Mon, 14 Oct 2019 10:51:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADFC58E0001; Mon, 14 Oct 2019 10:51:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CE028E0006; Mon, 14 Oct 2019 10:51:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 80D9E8E0001 for ; Mon, 14 Oct 2019 10:51:47 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 344254DBE for ; Mon, 14 Oct 2019 14:51:47 +0000 (UTC) X-FDA: 76042679454.17.clam61_66d4f26b64e63 X-HE-Tag: clam61_66d4f26b64e63 X-Filterd-Recvd-Size: 6454 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 14:51:46 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id b20so16954247ljj.5 for ; Mon, 14 Oct 2019 07:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Zl9j9N5g2XhcKzAZ6Cx7QAGYoUWVq9aZXTcu8wQiQfw=; b=PPtoDEJU0h4JnPMhPXkDkcYF4Pe2xnFKY77WyJmgnbwx/opDkf3EnHO/aSkQgb+Rr4 U98tG+8u0Tj7hHDt1NIwZ6GLdUyKZfOTmkitZvXvH4Bt1ylpX7zMVXakUeWYk41ID0EK zq9ybPcOqkAU/37IUUlahKQeGr4nLG6cVkfBDWAzfGnw8ZaI4g16fIhpigjPNxQ09z47 5BCHqsNVgO5pf9c+DUShNywqEcUVgeIdyQHSXWM6Qjw8dbzv5jfw6ZyO/DnJLDbJsPbs Qmy1Ki/10/Rh/k2iimoH7RrpMju9RUlqC91/56ewTgfbkpPd4zCYxzJ8+Ijcntg6Ysqr 0vFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Zl9j9N5g2XhcKzAZ6Cx7QAGYoUWVq9aZXTcu8wQiQfw=; b=f6vFpjBmCjTlLbTLivqZReR3Vx++HiVSGBPEf/AdAv52NvcnoDqLsTv9xVbWdwsmF/ YE3YZwmU2uB6uE1+B5BFSK15xHT4Os49mG2lPXaGOwHuVEtKJhzMpjJqaLAgvsq4vHWD z22YcaCa9Yt8B6mlfEjZC/y+i8e0xpqwWCMVWqTb8nh9nAqaybCCrxu4z32CqrAnzWfs lFoY2RVdeDfj+58ZGsBa0lMA8qv/imfoi+ZMoBLaiL4r9dk9V1QTkmw68KX3F2+/Gl4m Z25TYWavNX6xltMqHjoCfsAmbjCqOwSYAeZKZAx3YvpQfE90J1sUluqm3+TndfGfS8a/ poVw== X-Gm-Message-State: APjAAAVa/Z6+T2rpdh1Y5vjrvoxijkzYOH6A3pUzcEsxtuwHZAe+/63T pHHouhMTbqPs+Vz3aGpRjBIW4A== X-Google-Smtp-Source: APXvYqxUae3JOmHFPaEKUaEnf5tp7Lf4ZMZcnxinA7FNO7P2TrxkuYeHXeDS4ymI6ZKdgD2Ldu2SxQ== X-Received: by 2002:a2e:a0ca:: with SMTP id f10mr18271484ljm.83.1571064705032; Mon, 14 Oct 2019 07:51:45 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id x2sm4397741ljj.94.2019.10.14.07.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 07:51:44 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 70CAA101145; Mon, 14 Oct 2019 17:51:43 +0300 (+03) Date: Mon, 14 Oct 2019 17:51:43 +0300 From: "Kirill A. Shutemov" To: "Aneesh Kumar K.V" Cc: John Hubbard , kbuild test robot , kbuild-all@lists.01.org, Andrew Morton , Christoph Hellwig , Keith Busch , Ira Weiny , LKML , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH 2/2] mm/gup: fix a misnamed "write" argument: should be "flags" Message-ID: <20191014145143.hyi6fj6s6uquohzj@box> References: <20191013221155.382378-3-jhubbard@nvidia.com> <201910141316.DHpeevy3%lkp@intel.com> <20191014135234.7ak32pfir6du3xae@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 14, 2019 at 08:14:04PM +0530, Aneesh Kumar K.V wrote: > On 10/14/19 7:22 PM, Kirill A. Shutemov wrote: > > On Sun, Oct 13, 2019 at 11:43:10PM -0700, John Hubbard wrote: > > > On 10/13/19 11:12 PM, kbuild test robot wrote: > > > > Hi John, > > > > > > > > Thank you for the patch! Yet something to improve: > > > > > > > > [auto build test ERROR on linus/master] > > > > [cannot apply to v5.4-rc3 next-20191011] > > > > [if your patch is applied to the wrong git tree, please drop us a note to help > > > > improve the system. BTW, we also suggest to use '--base' option to specify the > > > > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > > > > > > > url: https://github.com/0day-ci/linux/commits/John-Hubbard/gup-c-gup_benchmark-c-trivial-fixes-before-the-storm/20191014-114158 > > > > config: powerpc-defconfig (attached as .config) > > > > compiler: powerpc64-linux-gcc (GCC) 7.4.0 > > > > reproduce: > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > > chmod +x ~/bin/make.cross > > > > # save the attached .config to linux build tree > > > > GCC_VERSION=7.4.0 make.cross ARCH=powerpc > > > > > > > > If you fix the issue, kindly add following tag > > > > Reported-by: kbuild test robot > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > > mm/gup.c: In function 'gup_hugepte': > > > > > > mm/gup.c:1990:33: error: 'write' undeclared (first use in this function); did you mean 'writeq'? > > > > if (!pte_access_permitted(pte, write)) > > > > ^~~~~ > > > > writeq > > > > mm/gup.c:1990:33: note: each undeclared identifier is reported only once for each function it appears in > > > > > > > > > > OK, so this shows that my cross-compiler test scripts are faulty lately, > > > sorry I missed this. > > > > > > But more importantly, the above missed case is an example of when "write" really > > > means "write", as opposed to meaning flags. > > > > > > Please put this patch on hold or drop it, until we hear from the authors as to how > > > they would like to resolve this. I suspect it will end up as something like: > > > > > > bool write = (flags & FOLL_WRITE); > > > > > > ...perhaps? > > > > Just use > > > > if (!pte_access_permitted(pte, flags & FOLL_WRITE)) > > > > as we have in gup_pte_range(). > > > > And add: > > > > Fixes: cbd34da7dc9a ("mm: move the powerpc hugepd code to mm/gup.c") > > > > b798bec4741bdd80224214fdd004c8e52698e42 isn't this the commit that need to > be mentioned in the Fixes: tag? Ah. Okay, I see you point. Yes, this is the sourch of the breakage. -- Kirill A. Shutemov