From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 333BEECE587 for ; Mon, 14 Oct 2019 14:11:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E906A2083B for ; Mon, 14 Oct 2019 14:11:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="IKeG2jcz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E906A2083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 99FEA8E0007; Mon, 14 Oct 2019 10:11:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9778F8E0001; Mon, 14 Oct 2019 10:11:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83E8B8E0007; Mon, 14 Oct 2019 10:11:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 615B78E0001 for ; Mon, 14 Oct 2019 10:11:54 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 101CF82FC758 for ; Mon, 14 Oct 2019 14:11:54 +0000 (UTC) X-FDA: 76042578948.03.net88_2da35f365cc4b X-HE-Tag: net88_2da35f365cc4b X-Filterd-Recvd-Size: 4028 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 14:11:53 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id t20so20270927qtr.10 for ; Mon, 14 Oct 2019 07:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IvIenCJzHo+g6OuA9cd9X9mP9xzIp/N5yCxiJYUBY1E=; b=IKeG2jczIn2/hbGefzwpalyXwOL8I+IESSyz5oZ01wurpwW2JDCrN4F/0afk8J0ICv x1Jln5cdJNzG+zcDKpTfDcARI48mI/w3twXA2UfxL7uboKEegSKBC8rYgI1cwq/Z9Dwj zeiwXie7Jk+bgfZucCxYe2J3hZwv86IqqE0v0d4lf/RnDH2MzKMKaNd57qSEuw13OV9q 6uQUvOvuJaq1frTPCkrQSrK3+k8uePioSqhhIf5vn9rblfzNF/5TlyodPDjrSEgn8DTf 35hWJ5qnW2h1CXcNLNDNA3elqgdoRB1BbEueSd+dLvA9/ROKf+tQ/nVzL0rjsedbjt9Y bTwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IvIenCJzHo+g6OuA9cd9X9mP9xzIp/N5yCxiJYUBY1E=; b=blO6b/BjAc8FKwU3fNeWP3PGHESMOik+slA9LhbtPrNDh26MyIqTqyG96sM/biWm15 krcfHJfIkl6PbcFGAGztsDsWIgxS1qsNVjufOcwnAdoqTYyaT4RXdDBa0RIEuGSW5+PB 1BDBBO9PHoBlR84Z+4ON3zykkq8D/n1E7Dg6PkqdOtfQLQ7OmvNwnBn5esNlqazSEypJ tOgf31wC6qLjWGeei90HnE0tWXhAiZLkjY+AtVKuh6/qW6KHqs/XYoBycBc19tXKGudT KZagO59KsGtajiMSRQpHT1zQxLC0jfYl6HvHIvFzkMsQfedNNX+PvLl5P/7XKOU1Fcsm Q0pA== X-Gm-Message-State: APjAAAWVISqIq2Gw+QkWlyWAbv1P3Zcvny7BySo+4TEkNUIPCJDDwZp1 Snl2a7zDU5my/GsPtl8NngCq9Q== X-Google-Smtp-Source: APXvYqwXMuAgZT5Grv+lwbM536hV1aSfFcio2x7Rt1wCSc7KtXRsEK1CgTF9G8o1bR+6eWoKeEuNzQ== X-Received: by 2002:a0c:e5c1:: with SMTP id u1mr31058635qvm.206.1571062312767; Mon, 14 Oct 2019 07:11:52 -0700 (PDT) Received: from soleen.tm1wkky2jk1uhgkn0ivaxijq1c.bx.internal.cloudapp.net ([40.117.208.181]) by smtp.gmail.com with ESMTPSA id x19sm8223186qkf.26.2019.10.14.07.11.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 07:11:51 -0700 (PDT) Date: Mon, 14 Oct 2019 14:11:50 +0000 From: Pavel Tatashin To: James Morse Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, bhsharma@redhat.com, linux-mm@kvack.org, mark.rutland@arm.com Subject: Re: [PATCH v6 02/17] arm64: hibernate: pass the allocated pgdp to ttbr0 Message-ID: <20191014141150.xt6z3gs3cu3rl3go@soleen.tm1wkky2jk1uhgkn0ivaxijq1c.bx.internal.cloudapp.net> References: <20191004185234.31471-1-pasha.tatashin@soleen.com> <20191004185234.31471-3-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19-10-11 19:17:22, James Morse wrote: > > Fixes: 0194e760f7d2 ("arm64: hibernate: avoid potential TLB conflict") > > (That was a 'break before make' fix, the affected code comes from: > 82869ac57b5d (""arm64: kernel: Add support for hibernate/suspend-to-disk)) > > But, it works in all one circumstances its used: we know all the top bits will be zero. > I agree its by accident and we should fix it. > > I don't think we should send it to stable. > Please drop the fixes tag, with that: OK > Reviewed-by: James Morse Thank you! Pasha