From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC0BECE587 for ; Mon, 14 Oct 2019 13:52:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D44522133F for ; Mon, 14 Oct 2019 13:52:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="IlQOIU9V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D44522133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 801678E0006; Mon, 14 Oct 2019 09:52:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78A2A8E0001; Mon, 14 Oct 2019 09:52:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677F08E0006; Mon, 14 Oct 2019 09:52:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 4077A8E0001 for ; Mon, 14 Oct 2019 09:52:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id D7B65181AEF1E for ; Mon, 14 Oct 2019 13:52:38 +0000 (UTC) X-FDA: 76042530396.26.news15_170555ec9d90d X-HE-Tag: news15_170555ec9d90d X-Filterd-Recvd-Size: 5815 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 13:52:38 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id y23so16691413lje.9 for ; Mon, 14 Oct 2019 06:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f9b7DTnSxRvT+GcqfkPH2X9rmIgB3LKKUuDW26EPx+E=; b=IlQOIU9V0/k9WH69ItvmTZuFdztr2V9aDLo0xk1sMct4aWBwk8sRXReuLZ2LYneqgH Vptsx/PLN+PjP0htJydrqQuT1nUfCgV0tc5ViZ9q28KhfbJNEMFK83EAD/w0EGI4v10D edZ/JcU4ONw4IL6cytAtVgvQBUtUUYVZ0uSxldRnlxPF9NoZvpKJryi49k92yzUw/wWA ESv6noE0SESJPPPtgZvufaasJVDi6YWW7H0b6QsgMidIuYuBIPNP3hzS1bQUp6Nakfu4 63Mh2/JSpTR9ZwkbzJtIP0hXSu+yA5U9vHNnAYjoDrJaqoe2KwcHl18SDmz5mJi3iRu5 Wzfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f9b7DTnSxRvT+GcqfkPH2X9rmIgB3LKKUuDW26EPx+E=; b=OVBUNbp9BxmdS6mr8j0WKGkBxhdzYeUfnsPRqBsfVarjdP+reiv6373CAbgDlr6K3b WH7jI/zC2zb9V1+BHxwIvgdnEZvhU5Ycs+1w6mURk6z8/zAXHRZW035WCPYdLr1PPyaK 9gq6UYMmIpErK4BCQCQX3/PcCl912QHFnw+eayJoKwjdj/6Fa46rP6dLynLwmNXSwdrf YI3CU4zDb+H7BcoN4VjkP+Xu2Mpd8RJn7G/72YtmcpH7AObRU3PBDMuen1mjJtP5asCb V2TNs9jrOa0vGmQd9fGtYTpPpXz0nLtjnQ7svF3GnWyH5PwaLDWHCNlOOgqDnQ1t8lKS MFVA== X-Gm-Message-State: APjAAAWRYGgGIf7CqllOz5wg8RRXUkPjlKjTYsXRlrVgz9Sp6SpPwCUC VJ464FB7JfivCRLsmvTqRNGdzQ== X-Google-Smtp-Source: APXvYqzCK6MZOUzCuyTxzwIH3ne+Pzp0UvqoxBQxOCxb6nOc31dDH5pWOjOnQwO5BaW1BeDb4dcgLw== X-Received: by 2002:a2e:9112:: with SMTP id m18mr5930341ljg.75.1571061155925; Mon, 14 Oct 2019 06:52:35 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id 207sm4961519lfn.0.2019.10.14.06.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 06:52:35 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id A16C3101288; Mon, 14 Oct 2019 16:52:34 +0300 (+03) Date: Mon, 14 Oct 2019 16:52:34 +0300 From: "Kirill A. Shutemov" To: John Hubbard Cc: kbuild test robot , kbuild-all@lists.01.org, Andrew Morton , Christoph Hellwig , "Aneesh Kumar K . V" , Keith Busch , Ira Weiny , LKML , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH 2/2] mm/gup: fix a misnamed "write" argument: should be "flags" Message-ID: <20191014135234.7ak32pfir6du3xae@box> References: <20191013221155.382378-3-jhubbard@nvidia.com> <201910141316.DHpeevy3%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 13, 2019 at 11:43:10PM -0700, John Hubbard wrote: > On 10/13/19 11:12 PM, kbuild test robot wrote: > > Hi John, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on linus/master] > > [cannot apply to v5.4-rc3 next-20191011] > > [if your patch is applied to the wrong git tree, please drop us a note to help > > improve the system. BTW, we also suggest to use '--base' option to specify the > > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > > > url: https://github.com/0day-ci/linux/commits/John-Hubbard/gup-c-gup_benchmark-c-trivial-fixes-before-the-storm/20191014-114158 > > config: powerpc-defconfig (attached as .config) > > compiler: powerpc64-linux-gcc (GCC) 7.4.0 > > reproduce: > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # save the attached .config to linux build tree > > GCC_VERSION=7.4.0 make.cross ARCH=powerpc > > > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot > > > > All errors (new ones prefixed by >>): > > > > mm/gup.c: In function 'gup_hugepte': > > > > mm/gup.c:1990:33: error: 'write' undeclared (first use in this function); did you mean 'writeq'? > > if (!pte_access_permitted(pte, write)) > > ^~~~~ > > writeq > > mm/gup.c:1990:33: note: each undeclared identifier is reported only once for each function it appears in > > > > OK, so this shows that my cross-compiler test scripts are faulty lately, > sorry I missed this. > > But more importantly, the above missed case is an example of when "write" really > means "write", as opposed to meaning flags. > > Please put this patch on hold or drop it, until we hear from the authors as to how > they would like to resolve this. I suspect it will end up as something like: > > bool write = (flags & FOLL_WRITE); > > ...perhaps? Just use if (!pte_access_permitted(pte, flags & FOLL_WRITE)) as we have in gup_pte_range(). And add: Fixes: cbd34da7dc9a ("mm: move the powerpc hugepd code to mm/gup.c") -- Kirill A. Shutemov