From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE03ECE58D for ; Mon, 14 Oct 2019 08:41:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F531207FF for ; Mon, 14 Oct 2019 08:41:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F531207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E1A128E0007; Mon, 14 Oct 2019 04:41:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCAF98E0001; Mon, 14 Oct 2019 04:41:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE1098E0007; Mon, 14 Oct 2019 04:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id AB8F48E0001 for ; Mon, 14 Oct 2019 04:41:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 597CA3CF6 for ; Mon, 14 Oct 2019 08:41:08 +0000 (UTC) X-FDA: 76041745416.06.lead44_44144259c8b47 X-HE-Tag: lead44_44144259c8b47 X-Filterd-Recvd-Size: 5177 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 08:41:07 +0000 (UTC) Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B66DEC057867 for ; Mon, 14 Oct 2019 08:41:06 +0000 (UTC) Received: by mail-pg1-f198.google.com with SMTP id r24so12192953pgj.17 for ; Mon, 14 Oct 2019 01:41:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4FdnQewgGZTEIB4IszhktM32Rs8jClJgBtHw5gOlpAo=; b=HhPpaaKTH8qCCYy2AmsfMkWb/6+/iiT3unQDs9XKM5/7NI1o748PQEpqREMGyV+y8p tYquFr5m9P1QA2fH15pNXyMfJooLFJuoml9rRckqfbCNlOUiVnwajz/utP1KYyGEsiUy 6nFRGjs1r095Vogf3dvl4XSWHs+kr/DkCUjFpUysvEkavCcs6ZQBtuwC7o8mB/8InQxz ahLDBoQSDLCASXvGqn2vlZOrKuaemyhAhUy4Op+Zys5LAwJozNsCqkkjZVkyQ7kBNPNO 4XT3mrgkD3p6y4RR5UWzMjThRwM8oFIXCyl3FyQuprsBNqy1b9ZzEOXJRQtLM30Poxbj QAzw== X-Gm-Message-State: APjAAAXZNFuXeG01Y0s6DJzTgEAPZlDBLO3sPWe+3S10Ytu3fAY+tPQb ux89pQUNjpvfJTnSAAj2zcciP74ljlSFHWM3Hgh+kkrz7f2iyT8v++rFr7bqSlKXJDBSIv+TXOj 54dVQD7NiRs4= X-Received: by 2002:a17:90a:cc12:: with SMTP id b18mr33167024pju.141.1571042465831; Mon, 14 Oct 2019 01:41:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqysi/gpDn1hQzUB8+LiD0F52xkMYWEOwsHT4NROhG1sYO4vX4yLKV+FbHcFJTSVGZHy6ELN0Q== X-Received: by 2002:a17:90a:cc12:: with SMTP id b18mr33166992pju.141.1571042465531; Mon, 14 Oct 2019 01:41:05 -0700 (PDT) Received: from xz-x1 ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id i10sm19242993pgb.79.2019.10.14.01.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 01:41:04 -0700 (PDT) Date: Mon, 14 Oct 2019 16:40:52 +0800 From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Hugh Dickins , Maya Gokhale , Jerome Glisse , Pavel Emelyanov , Johannes Weiner , Martin Cracauer , Matthew Wilcox , Shaohua Li , Marty McFadden , Andrea Arcangeli , Mike Kravetz , Denis Plotnikov , Mike Rapoport , Linus Torvalds , Mel Gorman , "Kirill A . Shutemov" , "Dr . David Alan Gilbert" Subject: Re: [PATCH v5 00/16] mm: Page fault enhancements Message-ID: <20191014084052.GB8666@xz-x1> References: <20190926093904.5090-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190926093904.5090-1-peterx@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 26, 2019 at 05:38:48PM +0800, Peter Xu wrote: > This is v5 of the series. As Matthew suggested, I split the previous > patch "mm: Return faster for non-fatal signals in user mode faults" > into a few smaller ones: > > 1. One patch to introduce fatal_signal_pending(), and use it in > archs that can directly apply > > 2. A few more patches to let the rest archs to use the new helper. > With that we can have an unified entry for signal detection > > 3. One last patch to change fatal_signal_pending() to detect > userspace non-fatal signal > > Nothing should have changed in the rest patches. Because the fault > retry patches will depend on the previous ones, I decided to simply > repost all the patches. > > Here's the new patchset layout: > > Patch 1-2: cleanup, and potential bugfix of hugetlbfs on fault retry > > Patch 3-9: let page fault to respond to non-fatal signals faster > > Patch 10: remove the userfaultfd NOPAGE emulation > > Patch 11-14: allow page fault to retry more than once > > Patch 15-16: let gup code to use FAULT_FLAG_KILLABLE too > > I would really appreciate any review comments for the series, > especially for the first two patches which IMHO are even not related > to this patchset and they should either cleanup or fix things. Ping.. IMHO this series should fix some real issues, e.g., the whole series targets to fix things like [1] or as patch 2 might fix potential bugs. I'd appreciate if it can get some more review comments. I didn't repost because the last patch only need a one-line change so I assume it does not affect the most rest of reviews. I can repost if anyone would like me to. Thanks, [1] https://lore.kernel.org/lkml/20171102193644.GB22686@redhat.com/ -- Peter Xu