From: Peter Xu <peterx@redhat.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
Hugh Dickins <hughd@google.com>, Maya Gokhale <gokhale2@llnl.gov>,
Jerome Glisse <jglisse@redhat.com>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Martin Cracauer <cracauer@cons.org>,
Matthew Wilcox <willy@infradead.org>, Shaohua Li <shli@fb.com>,
Marty McFadden <mcfadden8@llnl.gov>,
Andrea Arcangeli <aarcange@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Denis Plotnikov <dplotnikov@virtuozzo.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v5 00/16] mm: Page fault enhancements
Date: Mon, 14 Oct 2019 16:40:52 +0800 [thread overview]
Message-ID: <20191014084052.GB8666@xz-x1> (raw)
In-Reply-To: <20190926093904.5090-1-peterx@redhat.com>
On Thu, Sep 26, 2019 at 05:38:48PM +0800, Peter Xu wrote:
> This is v5 of the series. As Matthew suggested, I split the previous
> patch "mm: Return faster for non-fatal signals in user mode faults"
> into a few smaller ones:
>
> 1. One patch to introduce fatal_signal_pending(), and use it in
> archs that can directly apply
>
> 2. A few more patches to let the rest archs to use the new helper.
> With that we can have an unified entry for signal detection
>
> 3. One last patch to change fatal_signal_pending() to detect
> userspace non-fatal signal
>
> Nothing should have changed in the rest patches. Because the fault
> retry patches will depend on the previous ones, I decided to simply
> repost all the patches.
>
> Here's the new patchset layout:
>
> Patch 1-2: cleanup, and potential bugfix of hugetlbfs on fault retry
>
> Patch 3-9: let page fault to respond to non-fatal signals faster
>
> Patch 10: remove the userfaultfd NOPAGE emulation
>
> Patch 11-14: allow page fault to retry more than once
>
> Patch 15-16: let gup code to use FAULT_FLAG_KILLABLE too
>
> I would really appreciate any review comments for the series,
> especially for the first two patches which IMHO are even not related
> to this patchset and they should either cleanup or fix things.
Ping..
IMHO this series should fix some real issues, e.g., the whole series
targets to fix things like [1] or as patch 2 might fix potential
bugs. I'd appreciate if it can get some more review comments.
I didn't repost because the last patch only need a one-line change so
I assume it does not affect the most rest of reviews. I can repost if
anyone would like me to.
Thanks,
[1] https://lore.kernel.org/lkml/20171102193644.GB22686@redhat.com/
--
Peter Xu
prev parent reply other threads:[~2019-10-14 8:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 9:38 Peter Xu
2019-09-26 9:38 ` [PATCH v5 01/16] mm/gup: Rename "nonblocking" to "locked" where proper Peter Xu
2019-09-26 9:38 ` [PATCH v5 02/16] mm/gup: Fix __get_user_pages() on fault retry of hugetlb Peter Xu
2019-09-26 9:38 ` [PATCH v5 03/16] mm: Introduce fault_signal_pending() Peter Xu
2019-09-26 9:38 ` [PATCH v5 04/16] x86/mm: Use helper fault_signal_pending() Peter Xu
2019-09-26 9:38 ` [PATCH v5 05/16] arc/mm: " Peter Xu
2019-09-26 9:38 ` [PATCH v5 06/16] arm64/mm: " Peter Xu
2019-09-26 9:38 ` [PATCH v5 07/16] powerpc/mm: " Peter Xu
2019-09-26 9:38 ` [PATCH v5 08/16] sh/mm: " Peter Xu
2019-09-26 9:38 ` [PATCH v5 09/16] mm: Return faster for non-fatal signals in user mode faults Peter Xu
2019-09-26 9:38 ` [PATCH v5 10/16] userfaultfd: Don't retake mmap_sem to emulate NOPAGE Peter Xu
2019-09-26 9:38 ` [PATCH v5 11/16] mm: Introduce FAULT_FLAG_DEFAULT Peter Xu
2019-09-26 9:39 ` [PATCH v5 12/16] mm: Introduce FAULT_FLAG_INTERRUPTIBLE Peter Xu
2019-09-26 9:39 ` [PATCH v5 13/16] mm: Allow VM_FAULT_RETRY for multiple times Peter Xu
2019-09-26 9:39 ` [PATCH v5 14/16] mm/gup: " Peter Xu
2019-09-26 9:39 ` [PATCH v5 15/16] mm/gup: Allow to react to fatal signals Peter Xu
2019-09-26 9:39 ` [PATCH v5 16/16] mm/userfaultfd: Honor FAULT_FLAG_KILLABLE in fault path Peter Xu
2019-09-29 9:16 ` Peter Xu
2019-10-14 8:40 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014084052.GB8666@xz-x1 \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=cracauer@cons.org \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=gokhale2@llnl.gov \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcfadden8@llnl.gov \
--cc=mgorman@suse.de \
--cc=mike.kravetz@oracle.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shli@fb.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox