From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5352C10F14 for ; Sat, 12 Oct 2019 10:26:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A7B302087E for ; Sat, 12 Oct 2019 10:26:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bMUZja03" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7B302087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5250F8E0001; Sat, 12 Oct 2019 06:26:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5286B0005; Sat, 12 Oct 2019 06:26:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C3BC8E0001; Sat, 12 Oct 2019 06:26:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 1BD556B0003 for ; Sat, 12 Oct 2019 06:26:25 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 99B6B181AC9BF for ; Sat, 12 Oct 2019 10:26:24 +0000 (UTC) X-FDA: 76034753088.08.copy00_8f37c9560912c X-HE-Tag: copy00_8f37c9560912c X-Filterd-Recvd-Size: 4214 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Sat, 12 Oct 2019 10:26:24 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id u20so5661325plq.4 for ; Sat, 12 Oct 2019 03:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nubxQvzooG3xqOAkvCW/mgrS50yD/8svwdUIcIb/aj0=; b=bMUZja03elYEUfA1yoRTnnA3Y6yj02Ui0zGO9pqlSV1mzNt3Qg/4gKgJ7BlWy15F62 JZfeImVbs9Kw24kF2gk1333e+WlDZoQFpulKb5mcCwY2wPChMrPV5YCjNwHk8A897CWT ByGYYLlF/Es8v+0Wf4RHrvJKhuWGTobloYT4FT2YNigqtHjVum4UFECZR/6nD+3tKonV HIlAuQcBt3cZQD9qGNbZVTD3saRR+i6pIGYHRzqBcVch+1dMFFRIDuBT3wRV/5oTCc28 FF+SguQvcASRKl2BrsVOnZeScyPsSoTjlU+jUwMa05EytVYwcM/w6B2e22ngRE/+WXVl xqrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nubxQvzooG3xqOAkvCW/mgrS50yD/8svwdUIcIb/aj0=; b=ObJ3cdlsSFPBpAQwHddrN79FrtSPEjfG3IS7mGELacCvbTBcrGOybJXM2ypBYSxLsX cWwepcD9rjvN1Uq/htzwUGkECfltVRNw7BK57ImRQI2m6jkn+s8kG4inubyHaDnJiMOE tuSYisJnMsghtdbRC/MfOi3skVpYTj+6mZ4cFODVse5/4cdE7uLa8ivA1GwnZ5N+iqF+ YJ/aQivEvqRpap4Yn3uxP/5z4meduZ9SAYJJ5hBKdqG51nMTTz+I4KzVjV8zvFlxnHhB +iFEZW19KV7CRZyIIPhper7tTxZ4qXFyGKMmsoBYFaTMWKbiYkuNzrUgZd7RX5p49W1X NA+w== X-Gm-Message-State: APjAAAXnxP36HVJ4fc39/XUGfi2ISU2sU4C/0oHp6n19ERdmot6RQhaK 1Q/YOsbAh1GjSI5nBDKjxPs= X-Google-Smtp-Source: APXvYqzuLp4mDhP12axWjnFHiHl6Kd5nrn1gBAhdwBZM1TA0qgl17U+weQRU+FnDGFcBPbRyT42EAw== X-Received: by 2002:a17:902:8218:: with SMTP id x24mr18990545pln.139.1570875983156; Sat, 12 Oct 2019 03:26:23 -0700 (PDT) Received: from localhost.localdomain ([123.139.57.210]) by smtp.gmail.com with ESMTPSA id v3sm11377377pfn.18.2019.10.12.03.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2019 03:26:22 -0700 (PDT) From: Gaowei Pu To: Andrew Morton Cc: Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH v2] mm/mmap.c: use IS_ERR_VALUE to check return value of get_unmapped_area Date: Sat, 12 Oct 2019 18:25:12 +0800 Message-Id: <20191012102512.28051-1-pugaowei@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: get_unmapped_area already cover the offset_in_page() check and returned with error ptr. So replace offset_in_page() with IS_ERR_VALUE(). Signed-off-by: Gaowei Pu V2: fix compile warnning. --- mm/mmap.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 7e8c3e8ae75f..6aebfeb6a486 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1430,7 +1430,7 @@ unsigned long do_mmap(struct file *file, unsigned l= ong addr, * that it represents a valid section of the address space. */ addr =3D get_unmapped_area(file, addr, len, pgoff, flags); - if (offset_in_page(addr)) + if (IS_ERR_VALUE(addr)) return addr; =20 if (flags & MAP_FIXED_NOREPLACE) { @@ -2990,15 +2990,16 @@ static int do_brk_flags(unsigned long addr, unsig= ned long len, unsigned long fla struct rb_node **rb_link, *rb_parent; pgoff_t pgoff =3D addr >> PAGE_SHIFT; int error; + unsigned long mapped_addr; =20 /* Until we need other flags, refuse anything except VM_EXEC. */ if ((flags & (~VM_EXEC)) !=3D 0) return -EINVAL; flags |=3D VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT | mm->def_flags; =20 - error =3D get_unmapped_area(NULL, addr, len, 0, MAP_FIXED); - if (offset_in_page(error)) - return error; + mapped_addr =3D get_unmapped_area(NULL, addr, len, 0, MAP_FIXED); + if (IS_ERR_VALUE(mapped_addr)) + return mapped_addr; =20 error =3D mlock_future_check(mm, mm->def_flags, len); if (error) --=20 2.23.0