From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDF3C47404 for ; Fri, 11 Oct 2019 12:39:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2BB38206CD for ; Fri, 11 Oct 2019 12:39:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BB38206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D15288E0006; Fri, 11 Oct 2019 08:39:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC6218E0001; Fri, 11 Oct 2019 08:39:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB5248E0006; Fri, 11 Oct 2019 08:39:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 98EBD8E0001 for ; Fri, 11 Oct 2019 08:39:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 589B0180AD80B for ; Fri, 11 Oct 2019 12:39:56 +0000 (UTC) X-FDA: 76031460792.01.bite26_56a7c7b0acd4f X-HE-Tag: bite26_56a7c7b0acd4f X-Filterd-Recvd-Size: 2553 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Oct 2019 12:39:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8920A30224AA; Fri, 11 Oct 2019 12:39:54 +0000 (UTC) Received: from bfoster (dhcp-41-2.bos.redhat.com [10.18.41.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08B005DD63; Fri, 11 Oct 2019 12:39:53 +0000 (UTC) Date: Fri, 11 Oct 2019 08:39:52 -0400 From: Brian Foster To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/26] xfs: correctly acount for reclaimable slabs Message-ID: <20191011123952.GE61257@bfoster> References: <20191009032124.10541-1-david@fromorbit.com> <20191009032124.10541-6-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009032124.10541-6-david@fromorbit.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 11 Oct 2019 12:39:54 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 09, 2019 at 02:21:03PM +1100, Dave Chinner wrote: > From: Dave Chinner > > The XFS inode item slab actually reclaimed by inode shrinker > callbacks from the memory reclaim subsystem. These should be marked > as reclaimable so the mm subsystem has the full picture of how much > memory it can actually reclaim from the XFS slab caches. > > Signed-off-by: Dave Chinner > --- Reviewed-by: Brian Foster > fs/xfs/xfs_super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 8d1df9f8be07..f0aff1f034e6 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1919,7 +1919,7 @@ xfs_init_zones(void) > > xfs_ili_zone = > kmem_zone_init_flags(sizeof(xfs_inode_log_item_t), "xfs_ili", > - KM_ZONE_SPREAD, NULL); > + KM_ZONE_SPREAD | KM_ZONE_RECLAIM, NULL); > if (!xfs_ili_zone) > goto out_destroy_inode_zone; > xfs_icreate_zone = kmem_zone_init(sizeof(struct xfs_icreate_item), > -- > 2.23.0.rc1 >