From: -Gary- <me@garybgenett.net>
To: Qian Cai <cai@lca.pw>, Vlastimil Babka <vbabka@suse.cz>
Cc: Hugh Dickins <hughd@google.com>, linux-mm@kvack.org
Subject: Re: [PATCH] shmem: add shmem_size option for full filesystem
Date: Wed, 9 Oct 2019 11:45:21 -0700 [thread overview]
Message-ID: <20191009184520.GE22291@spider> (raw)
In-Reply-To: <E278467F-D56E-4906-AD8A-1035F3A962D1@lca.pw>
From Qian:
> Hide it under the EXPERT does not mean the bar is lower to justify when introduced a new config option. What’s the benefits of this vs squashfs/resize?
From Vlastimil:
> Users can override the default via a mount option, no?
> Can the initramfs boot parameter specify the needed mount option
> somehow? If not, could we detect that we are mounting an initramfs, and
> size it accordingly over 50%? Do we know in advance how much we need?
> I'd rather avoid a new config option for this, if possible.
Thank you for clarifying all of that, Qian and Vlastimil. I have been making the assumption, apparently mistaken, that adding kernel configuration options is a trivial change. I stand educated.
Thank you for your ongoing patience with my passion regarding this. I am *not* a kernel developer, understand and appreciate the work involved, and know there are many other important things which need attention.
I concede, but am going to submit one final patch which simply makes the value a define.
My fundamental issue/fix here is that it is a magic token buried in the code, and it should at least be a clearly defined default, as a matter of principle. This will also make pre-compile sed/awk hacking much more reliable, for those so inclined.
If even that change is unpalatable, I will graciously accept a simple "reject, based on previous discussion", with gratitude. <^)
Thank you again for your consideration, and all of your hard work and contributions to the community.
Happy Hacking!
-- Gary
next prev parent reply other threads:[~2019-10-09 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 20:17 Gary B. Genett
2019-10-09 11:12 ` Qian Cai
2019-10-09 18:45 ` -Gary- [this message]
2019-10-09 11:56 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009184520.GE22291@spider \
--to=me@garybgenett.net \
--cc=cai@lca.pw \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox