From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF6C2C47404 for ; Wed, 9 Oct 2019 12:32:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA304206C0 for ; Wed, 9 Oct 2019 12:32:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA304206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 510338E0005; Wed, 9 Oct 2019 08:32:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C0518E0003; Wed, 9 Oct 2019 08:32:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D6F88E0005; Wed, 9 Oct 2019 08:32:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id 1EF4A8E0003 for ; Wed, 9 Oct 2019 08:32:20 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id BBB6552D6 for ; Wed, 9 Oct 2019 12:32:19 +0000 (UTC) X-FDA: 76024183998.03.aunt59_3155c67e80521 X-HE-Tag: aunt59_3155c67e80521 X-Filterd-Recvd-Size: 3444 Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Oct 2019 12:32:18 +0000 (UTC) Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 95FD72B76B81C23962B2; Wed, 9 Oct 2019 20:31:41 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Wed, 9 Oct 2019 20:31:32 +0800 From: YueHaibing To: David Howells , Andrew Morton , Vitaly Wool , "Henry Burns" , Shakeel Butt , "Stephen Rothwell" CC: YueHaibing , , , Subject: [PATCH -next] mm/z3fold.c: remove set but not used variable 'newpage' Date: Wed, 9 Oct 2019 12:31:11 +0000 Message-ID: <20191009123111.80425-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Fixes gcc '-Wunused-but-set-variable' warning: mm/z3fold.c: In function 'compact_single_buddy': mm/z3fold.c:693:16: warning: variable 'newpage' set but not used [-Wunused-but-set-variable] mm/z3fold.c:664:13: warning: variable 'bud' set but not used [-Wunused-but-set-variable] It is never used, so can be removed. Signed-off-by: YueHaibing --- mm/z3fold.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 25713a4a7186..d48d0ec3bcdd 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -661,7 +661,6 @@ static struct z3fold_header *compact_single_buddy(str= uct z3fold_header *zhdr) struct z3fold_pool *pool =3D zhdr_to_pool(zhdr); void *p =3D zhdr; unsigned long old_handle =3D 0; - enum buddy bud; size_t sz =3D 0; struct z3fold_header *new_zhdr =3D NULL; int first_idx =3D __idx(zhdr, FIRST); @@ -673,24 +672,20 @@ static struct z3fold_header *compact_single_buddy(s= truct z3fold_header *zhdr) * the page lock is already taken */ if (zhdr->first_chunks && zhdr->slots->slot[first_idx]) { - bud =3D FIRST; p +=3D ZHDR_SIZE_ALIGNED; sz =3D zhdr->first_chunks << CHUNK_SHIFT; old_handle =3D (unsigned long)&zhdr->slots->slot[first_idx]; } else if (zhdr->middle_chunks && zhdr->slots->slot[middle_idx]) { - bud =3D MIDDLE; p +=3D zhdr->start_middle << CHUNK_SHIFT; sz =3D zhdr->middle_chunks << CHUNK_SHIFT; old_handle =3D (unsigned long)&zhdr->slots->slot[middle_idx]; } else if (zhdr->last_chunks && zhdr->slots->slot[last_idx]) { - bud =3D LAST; p +=3D PAGE_SIZE - (zhdr->last_chunks << CHUNK_SHIFT); sz =3D zhdr->last_chunks << CHUNK_SHIFT; old_handle =3D (unsigned long)&zhdr->slots->slot[last_idx]; } =20 if (sz > 0) { - struct page *newpage; enum buddy new_bud =3D HEADLESS; short chunks =3D size_to_chunks(sz); void *q; @@ -699,7 +694,6 @@ static struct z3fold_header *compact_single_buddy(str= uct z3fold_header *zhdr) if (!new_zhdr) return NULL; =20 - newpage =3D virt_to_page(new_zhdr); if (WARN_ON(new_zhdr =3D=3D zhdr)) goto out_fail;