Re: [PATCH] shmem: add shmem_size option, set filesystem size

[-Gary- <me@garybgenett.net>]

> > At the least, it should be a "#define", or something.  Right now it is a hard-coded magic token.
>
> I am not sure if it worth the complication. Right now, you have the choice of resizing shmem like every body else or increasing your system memory a bit.
>
> If there are more compiling reasons to bump the limit, it is probably more appropriate to make it the default to use something like 75% memory if there isn’t much side-effect.

Thank you again, Qian.  I appreciate the conversation and coaching!

That makes perfect sense.  I agree with the effort to keep things tidy, efficient and supportable.  With your blessing, I will submit a separate patch that only adds a configuration option to set the number of pages, and does not perform any additional math or steps other than reporting the value.  This will at least make it a defined value rather than a magic token, and will allow any expert users who need it to change the value.

I'm very reluctant, if not outright opposed, to changing the default, regardless of how compelling the case.  The possible side-effects of that change in behavior are unforeseen, and the scope of testing required is infeasible.  I sense that you agree with this.

I hope my subsequent patch is low-impact enough to be accepted.

It means a lot that you took the time to review and comment on my work.  I do greatly appreciate it.  This was my first kernel patch submission, and you made it a good experience.  <^)

-- Gary