From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F76C10F14 for ; Tue, 8 Oct 2019 14:55:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6338B217D7 for ; Tue, 8 Oct 2019 14:55:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6338B217D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE8BB8E0005; Tue, 8 Oct 2019 10:55:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D99CA8E0003; Tue, 8 Oct 2019 10:55:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAF1A8E0005; Tue, 8 Oct 2019 10:55:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id A24BD8E0003 for ; Tue, 8 Oct 2019 10:55:41 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 0473C180AD803 for ; Tue, 8 Oct 2019 14:55:41 +0000 (UTC) X-FDA: 76020916482.04.key28_4ea2be02b3b3d X-HE-Tag: key28_4ea2be02b3b3d X-Filterd-Recvd-Size: 4470 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Oct 2019 14:55:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 50520ADDC; Tue, 8 Oct 2019 14:55:38 +0000 (UTC) Date: Tue, 8 Oct 2019 16:55:37 +0200 From: Michal Hocko To: "Kirill A. Shutemov" Cc: Vlastimil Babka , Yang Shi , kirill.shutemov@linux.intel.com, ktkhai@virtuozzo.com, hannes@cmpxchg.org, hughd@google.com, shakeelb@google.com, rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: thp: move deferred split queue to memcg's nodeinfo Message-ID: <20191008145537.GP6681@dhcp22.suse.cz> References: <1569968203-64647-1-git-send-email-yang.shi@linux.alibaba.com> <20191002084304.GI15624@dhcp22.suse.cz> <30421920-4fdb-767a-6ef2-60187932c414@suse.cz> <20191007143030.GN2381@dhcp22.suse.cz> <20191008144437.fr374cxtpnrnnjsv@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191008144437.fr374cxtpnrnnjsv@box> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 08-10-19 17:44:37, Kirill A. Shutemov wrote: > On Mon, Oct 07, 2019 at 04:30:30PM +0200, Michal Hocko wrote: > > On Mon 07-10-19 16:19:59, Vlastimil Babka wrote: > > > On 10/2/19 10:43 AM, Michal Hocko wrote: > > > > On Wed 02-10-19 06:16:43, Yang Shi wrote: > > > >> The commit 87eaceb3faa59b9b4d940ec9554ce251325d83fe ("mm: thp: make > > > >> deferred split shrinker memcg aware") makes deferred split queue per > > > >> memcg to resolve memcg pre-mature OOM problem. But, all nodes end up > > > >> sharing the same queue instead of one queue per-node before the commit. > > > >> It is not a big deal for memcg limit reclaim, but it may cause global > > > >> kswapd shrink THPs from a different node. > > > >> > > > >> And, 0-day testing reported -19.6% regression of stress-ng's madvise > > > >> test [1]. I didn't see that much regression on my test box (24 threads, > > > >> 48GB memory, 2 nodes), with the same test (stress-ng --timeout 1 > > > >> --metrics-brief --sequential 72 --class vm --exclude spawn,exec), I saw > > > >> average -3% (run the same test 10 times then calculate the average since > > > >> the test itself may have most 15% variation according to my test) > > > >> regression sometimes (not every time, sometimes I didn't see regression > > > >> at all). > > > >> > > > >> This might be caused by deferred split queue lock contention. With some > > > >> configuration (i.e. just one root memcg) the lock contention my be worse > > > >> than before (given 2 nodes, two locks are reduced to one lock). > > > >> > > > >> So, moving deferred split queue to memcg's nodeinfo to make it NUMA > > > >> aware again. > > > >> > > > >> With this change stress-ng's madvise test shows average 4% improvement > > > >> sometimes and I didn't see degradation anymore. > > > > > > > > My concern about this getting more and more complex > > > > (http://lkml.kernel.org/r/20191002084014.GH15624@dhcp22.suse.cz) holds > > > > here even more. Can we step back and reconsider the whole thing please? > > > > > > What about freeing immediately after split via workqueue and also have a > > > synchronous version called before going oom? Maybe there would be also > > > other things that would benefit from this scheme instead of traditional > > > reclaim and shrinkers? > > > > That is exactly what we have discussed some time ago. > > Yes, I've posted the patch: > > http://lkml.kernel.org/r/20190827125911.boya23eowxhqmopa@box > > But I still not sure that the approach is right. I expect it to trigger > performance regressions. For system with pleanty of free memory, we will > just pay split cost for nothing in many cases. I suspect it got lost in the email thread. Care to send as a separate RFC patch? We can put it to mm for a cycle or two to see how it behaves. The patch seems quite simple and straightforward from a very quick glance. It is a bit of a hack that it piggybacks on top of the shrinker code which should ideally go away if this approach works but that is a minor detail. -- Michal Hocko SUSE Labs