From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA324ECE58C for ; Mon, 7 Oct 2019 13:52:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C4DC20867 for ; Mon, 7 Oct 2019 13:52:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ic0JkvFI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C4DC20867 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D6E218E0005; Mon, 7 Oct 2019 09:52:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF83A8E0003; Mon, 7 Oct 2019 09:52:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE4CB8E0005; Mon, 7 Oct 2019 09:52:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 95E158E0003 for ; Mon, 7 Oct 2019 09:52:04 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 37CA662F4 for ; Mon, 7 Oct 2019 13:52:04 +0000 (UTC) X-FDA: 76017127368.19.songs35_2f159221a5604 X-HE-Tag: songs35_2f159221a5604 X-Filterd-Recvd-Size: 6848 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Oct 2019 13:52:03 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id b9so15452053wrs.0 for ; Mon, 07 Oct 2019 06:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NqDKw2q0fE+vHWOgUAiru/n1NoCQkdZ2AUuiN/uBGU8=; b=ic0JkvFI48xbG9WtluZM0Hf2PaBXHEnROez7bzryeyJvDMyBL5e6TbbMM0jUfHQLcj N60dwtHrD83rN8DO0nAWlFYhXP8KC2u6M4pUl5c0nz2hn71y23NUwAnaxYFkxrH4ok93 +qfxQR+o9B6oGOhK4vKltZbgeMC0rGmYE19yAJrAQ1/yj8WoUn37LJOzT1mjCMj3nWxf T+d+hYdoZYOlliAXcaBDcfhvlDagJJO/aYGfkcviRX3zUAubMvNmWNjd1pemdF4Sv8ip gy5V18KXkquelqXpy56UmV1xBTQrBaryDxBotNjsV4DVgQZQSEqRJYVQMZJf/ufLy8+j SRrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=NqDKw2q0fE+vHWOgUAiru/n1NoCQkdZ2AUuiN/uBGU8=; b=OpJhE4aNr/Pr3WXCI+QA1jAl2t3ZLumIWN8wZysiATCBrqO9RwuJaoT11uuM4qaGhK HBUYAsUW5dAPxd6nQMu/Exsfq9sgeSVQ8evpFuG2yywOTzejOOPxJs2nD3jtjlXiCsCE QjLKtY5crFCu+ySBHSzhDIsJgLkz7A8lfzdGkVoD5uYOMDPqr8t4ICyCCqNa4yEVZACO 3JN1cYE7hjc8deXxJDiveKNxQN4sMwa4btlgtLb5RUz5Wkvd5ytp3RNdVlncyyIiLOBQ 8EnSe+iirftU4j3s4mVBIQuEr/zwhhaIPs0MPcnYUKGbPgtaPg6mFGKVFqo7lFBJmzTG VjCw== X-Gm-Message-State: APjAAAX3CMso1jm3CjZqQwEZQjUGLKEPmQy9kD+Gb5xiIB1+v5vqTUck D0JWULXNANN6rzGsyWOwUGE= X-Google-Smtp-Source: APXvYqwFD0AmO4hRi+9l8ADVfmGE8OkR9Fnj4QRZ24lM5fadabYkivM/y6etDxaG7ZOadEedrbv48w== X-Received: by 2002:a5d:6441:: with SMTP id d1mr16719177wrw.254.1570456322346; Mon, 07 Oct 2019 06:52:02 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id q19sm41499530wra.89.2019.10.07.06.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 06:52:01 -0700 (PDT) Date: Mon, 7 Oct 2019 15:51:58 +0200 From: Ingo Molnar To: "Kirill A. Shutemov" Cc: Anshuman Khandual , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers Message-ID: <20191007135158.GA36360@gmail.com> References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> <20191007132607.4q537nauwfn5thol@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007132607.4q537nauwfn5thol@box> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Kirill A. Shutemov wrote: > On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: > > > > * Anshuman Khandual wrote: > > > > > This adds a test module which will validate architecture page table helpers > > > and accessors regarding compliance with generic MM semantics expectations. > > > This will help various architectures in validating changes to the existing > > > page table helpers or addition of new ones. > > > > > > Test page table and memory pages creating it's entries at various level are > > > all allocated from system memory with required alignments. If memory pages > > > with required size and alignment could not be allocated, then all depending > > > individual tests are skipped. > > > > > diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h > > > index 52e5f5f2240d..b882792a3999 100644 > > > --- a/arch/x86/include/asm/pgtable_64_types.h > > > +++ b/arch/x86/include/asm/pgtable_64_types.h > > > @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) > > > #define pgtable_l5_enabled() 0 > > > #endif /* CONFIG_X86_5LEVEL */ > > > > > > +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) > > > + > > > extern unsigned int pgdir_shift; > > > extern unsigned int ptrs_per_p4d; > > > > Any deep reason this has to be a macro instead of proper C? > > It's a way to override the generic mm_p4d_folded(). It can be rewritten > as inline function + define. Something like: > > #define mm_p4d_folded mm_p4d_folded > static inline bool mm_p4d_folded(struct mm_struct *mm) > { > return !pgtable_l5_enabled(); > } > > But I don't see much reason to be more verbose here than needed. C type checking? Documentation? Yeah, I know it's just a one-liner, but the principle of the death by a thousand cuts applies here. BTW., any reason this must be in the low level pgtable_64_types.h type header, instead of one of the API level header files? Thanks, Ingo