From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5A09C47404 for ; Sat, 5 Oct 2019 12:35:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 850A1222CE for ; Sat, 5 Oct 2019 12:35:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 850A1222CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2DAF48E0003; Sat, 5 Oct 2019 08:35:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28B476B0008; Sat, 5 Oct 2019 08:35:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1536B8E0003; Sat, 5 Oct 2019 08:35:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E31266B0006 for ; Sat, 5 Oct 2019 08:35:32 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 5AAE0180AD7C3 for ; Sat, 5 Oct 2019 12:35:32 +0000 (UTC) X-FDA: 76009676904.22.bit34_879565bca2319 X-HE-Tag: bit34_879565bca2319 X-Filterd-Recvd-Size: 2657 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Sat, 5 Oct 2019 12:35:31 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2019 05:35:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,260,1566889200"; d="scan'208";a="222425250" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 05 Oct 2019 05:35:25 -0700 Date: Sat, 5 Oct 2019 20:35:07 +0800 From: Wei Yang To: Matthew Wilcox Cc: Wei Yang , akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, jglisse@redhat.com, mike.kravetz@oracle.com, riel@surriel.com, khlebnikov@yandex-team.ru, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/rmap.c: reuse mergeable anon_vma as parent when fork Message-ID: <20191005123507.GA7222@richard> Reply-To: Wei Yang References: <20191004160632.30251-1-richardw.yang@linux.intel.com> <20191004161120.GI32665@bombadil.infradead.org> <20191004234845.GB15415@richard> <20191005011554.GQ32665@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191005011554.GQ32665@bombadil.infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 04, 2019 at 06:15:54PM -0700, Matthew Wilcox wrote: >On Sat, Oct 05, 2019 at 07:48:45AM +0800, Wei Yang wrote: >> On Fri, Oct 04, 2019 at 09:11:20AM -0700, Matthew Wilcox wrote: >> >On Sat, Oct 05, 2019 at 12:06:32AM +0800, Wei Yang wrote: >> >> After this change, kernel build test reduces 20% anon_vma allocation. >> > >> >But does it have any effect on elapsed time or peak memory consumption? >> >> Do the same kernel build test and record time: >> >> >> Origin >> >> real 2m50.467s >> user 17m52.002s >> sys 1m51.953s >> >> real 2m48.662s >> user 17m55.464s >> sys 1m50.553s >> >> real 2m51.143s >> user 17m59.687s >> sys 1m53.600s >> >> >> Patched >> >> real 2m43.733s >> user 17m25.705s >> sys 1m41.791s >> >> real 2m47.146s >> user 17m47.451s >> sys 1m43.474s >> >> real 2m45.763s >> user 17m38.230s >> sys 1m42.102s >> >> >> For time in sys, it reduced 8.5%. > >That's compelling! Yep, looks good :-) -- Wei Yang Help you, Help me