From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2352FC4360C for ; Sat, 5 Oct 2019 01:22:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C322120830 for ; Sat, 5 Oct 2019 01:22:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C322120830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D0E86B0003; Fri, 4 Oct 2019 21:22:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6594F6B0005; Fri, 4 Oct 2019 21:22:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 520B56B0006; Fri, 4 Oct 2019 21:22:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 26FA36B0003 for ; Fri, 4 Oct 2019 21:22:13 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id A6D7C180AD7C3 for ; Sat, 5 Oct 2019 01:22:12 +0000 (UTC) X-FDA: 76007980104.27.thumb60_4d501f3821935 X-HE-Tag: thumb60_4d501f3821935 X-Filterd-Recvd-Size: 1550 Received: from r3-11.sinamail.sina.com.cn (r3-11.sinamail.sina.com.cn [202.108.3.11]) by imf03.hostedemail.com (Postfix) with SMTP for ; Sat, 5 Oct 2019 01:22:10 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([124.64.2.167]) by sina.com with ESMTP id 5D97F03F00014E89; Sat, 5 Oct 2019 09:22:08 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 51862549284857 From: Hillf Danton To: Matthew Wilcox Cc: fsdevl , mm , linux Subject: Re: [PATCH 06/15] xfs: Pass a page to xfs_finish_page_writeback Date: Sat, 5 Oct 2019 09:21:55 +0800 Message-Id: <20191005012155.2252-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.022633, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 5 Oct 2019 03:35:36 +0800 Matthew Wilcox wrote: >=20 > On Thu, Oct 03, 2019 at 12:08:46PM +0800, Hillf Danton wrote: > > > > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle) > > > > > > The only part of the bvec we were accessing was the bv_page, so jus= t > > > pass that instead of the whole bvec. > > > > Change is added in ABI without a bit of win. > > Changes like this are not needed. >=20 > ABI? This is a static function. The original recommendation to do thi= s > came from Christoph, who I would trust over you as a referee of what > changes to make to XFS. Hehe, I try to see your point, nice code will never be able to escape standing ovation.