From: Hillf Danton <hdanton@sina.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: fsdevl <linux-fsdevel@vger.kernel.org>, mm <linux-mm@kvack.org>,
linux <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/15] xfs: Pass a page to xfs_finish_page_writeback
Date: Sat, 5 Oct 2019 09:21:55 +0800 [thread overview]
Message-ID: <20191005012155.2252-1-hdanton@sina.com> (raw)
On Sat, 5 Oct 2019 03:35:36 +0800 Matthew Wilcox wrote:
>
> On Thu, Oct 03, 2019 at 12:08:46PM +0800, Hillf Danton wrote:
> >
> > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle)
> > >
> > > The only part of the bvec we were accessing was the bv_page, so just
> > > pass that instead of the whole bvec.
> >
> > Change is added in ABI without a bit of win.
> > Changes like this are not needed.
>
> ABI? This is a static function. The original recommendation to do this
> came from Christoph, who I would trust over you as a referee of what
> changes to make to XFS.
Hehe, I try to see your point, nice code will never be able to
escape standing ovation.
next reply other threads:[~2019-10-05 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 1:21 Hillf Danton [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-25 0:51 [RFC 00/15] Large pages in the page-cache Matthew Wilcox
2019-09-25 0:52 ` [PATCH 06/15] xfs: Pass a page to xfs_finish_page_writeback Matthew Wilcox
2019-10-03 4:08 ` Hillf Danton
2019-10-04 19:35 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005012155.2252-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox