From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A81A2C4360C for ; Fri, 4 Oct 2019 12:37:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 608F6222C8 for ; Fri, 4 Oct 2019 12:37:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="QxcuWXbC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 608F6222C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D21A6B0005; Fri, 4 Oct 2019 08:37:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08C298E0003; Fri, 4 Oct 2019 08:37:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB3628E0003; Fri, 4 Oct 2019 08:37:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id CB9656B0005 for ; Fri, 4 Oct 2019 08:37:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 582AC824CA22 for ; Fri, 4 Oct 2019 12:37:37 +0000 (UTC) X-FDA: 76006053354.21.women42_5f82eba23614d X-HE-Tag: women42_5f82eba23614d X-Filterd-Recvd-Size: 6428 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Oct 2019 12:37:36 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id r9so5648571edl.10 for ; Fri, 04 Oct 2019 05:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=FCR5dbyFL4JcthMLmOPGE4IWt+rC/CEpp1RTDjU/JI0=; b=QxcuWXbCCNxVcngInfcaD8sQPGmbvwR9uvtRh6g+yghAM03yT5vEYmXLb5J0dLFMie /Kt7C2MzYByQ3WAdirPwd2H0a6g56Hw74YEgRh9gdoHrW6duA/S3aSUySspepW5NYh6P zwiAQSZO/zF520LziTlfYf65ZbZVQHA3f67yecMMr2fV1xro9QC7toOY+M76PiNlr28R x1CmlXn1VncpN4uEZNLYvVYriPM8+sSUaOXCle9jg3h/PXJ63vtPy4JIipEQm+obBfRN S5AvS8w0q8BqAmljMp/GiRQrHEiaC8tnvhD2YsPX7seJySpnZP9RouXFwKjrWZsSTrXy 2W/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=FCR5dbyFL4JcthMLmOPGE4IWt+rC/CEpp1RTDjU/JI0=; b=jghV/VZJ+GKSZWcmRVdOGrXCFC9/di8H5j9IMvHrbkGPWyObT1lVzYZHXbdE6Dk3Jk RdY/hSdYY+0UtLEI4q/tVzLRSbB9keJs2aGF2EixhJZ0qztbFGaxG54Gz/OtQ3PZQ8Ui gSy4CUEVEwXtNp9fCaVTOZzg/EpyXnFpyFSxFKe5V0TwMic1Nx+P3c/IanrDfFmQUd2a PmgGLQvZnwHSBm9b5cgI477k92I5d+ES0+IisiRboq8v6uPnniYRgOyDx+d7UmRDXiWv 8A/pm1unQMGC7xSDDt33FZPjcVQiNe/6NWorQD1l2NPZO384wlWlsRAzq/sUmUmPcTof uwTA== X-Gm-Message-State: APjAAAWwNN/CyW/BDMtngezXtsfyXD2qpWXGjaX+UKDEt/KKb72sv509 LF89E77hrZ1z0a13rl6K+Iu/kA== X-Google-Smtp-Source: APXvYqwaN9Piat7yNEqCbXckJquXUPHqHDwzQ6A5013aE6ofJKK6A8PoqNI0M1Tpps3POLL5d8VhLw== X-Received: by 2002:aa7:d386:: with SMTP id x6mr14874136edq.264.1570192654850; Fri, 04 Oct 2019 05:37:34 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id gx14sm584793ejb.38.2019.10.04.05.37.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Oct 2019 05:37:33 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 50C4A102143; Fri, 4 Oct 2019 15:37:32 +0300 (+03) Date: Fri, 4 Oct 2019 15:37:32 +0300 From: "Kirill A. Shutemov" To: Thomas =?utf-8?Q?Hellstr=C3=B6m_=28VMware=29?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, Thomas Hellstrom , Andrew Morton , Matthew Wilcox , Will Deacon , Peter Zijlstra , Rik van Riel , Minchan Kim , Michal Hocko , Huang Ying , =?utf-8?B?SsOpcsO0bWU=?= Glisse Subject: Re: [PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code Message-ID: <20191004123732.xpr3vroee5mhg2zt@box.shutemov.name> References: <20191002134730.40985-1-thomas_os@shipmail.org> <20191002134730.40985-3-thomas_os@shipmail.org> <20191003111708.sttkkrhiidleivc6@box> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 03, 2019 at 01:32:45PM +0200, Thomas Hellstr=F6m (VMware) wro= te: > > > + * If @mapping allows faulting of huge pmds and puds, it is desi= rable > > > + * that its huge_fault() handler blocks while this function is r= unning on > > > + * @mapping. Otherwise a race may occur where the huge entry is = split when > > > + * it was intended to be handled in a huge entry callback. This = requires an > > > + * external lock, for example that @mapping->i_mmap_rwsem is hel= d in > > > + * write mode in the huge_fault() handlers. > > Em. No. We have ptl for this. It's the only lock required (plus mmap_= sem > > on read) to split PMD entry into PTE table. And it can happen not onl= y > > from fault path. > >=20 > > If you care about splitting compound page under you, take a pin or lo= ck a > > page. It will block split_huge_page(). > >=20 > > Suggestion to block fault path is not viable (and it will not happen > > magically just because of this comment). > >=20 > I was specifically thinking of this: >=20 > https://elixir.bootlin.com/linux/latest/source/mm/pagewalk.c#L103 >=20 > If a huge pud is concurrently faulted in here, it will immediatly get s= plit > without getting processed in pud_entry(). An external lock would protec= t > against that, but that's perhaps a bug in the pagewalk code?=A0 For pmd= s the > situation is not the same since when pte_entry is used, all pmds will > unconditionally get split. I *think* it should be fixed with something like this (there's no pud_trans_unstable() yet): diff --git a/mm/pagewalk.c b/mm/pagewalk.c index d48c2a986ea3..221a3b945f42 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -102,10 +102,11 @@ static int walk_pud_range(p4d_t *p4d, unsigned long= addr, unsigned long end, break; continue; } + } else { + split_huge_pud(walk->vma, pud, addr); } =20 - split_huge_pud(walk->vma, pud, addr); - if (pud_none(*pud)) + if (pud_none(*pud) || pud_trans_unstable(*pud)) goto again; =20 if (ops->pmd_entry || ops->pte_entry) Or better yet converted to what we do on pmd level. Honestly, all the code around PUD THP missing a lot of ground work. Rushing it upstream for DAX was not a right move. > There's a similar more scary race in >=20 > https://elixir.bootlin.com/linux/latest/source/mm/memory.c#L3931 >=20 > It looks like if a concurrent thread faults in a huge pud just after th= e > test for pud_none in that pmd_alloc, things might go pretty bad. Hm? It will fail the next pmd_none() check under ptl. Do you have a particular racing scenarion? --=20 Kirill A. Shutemov