From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50BD2C10F14 for ; Thu, 3 Oct 2019 08:55:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1ABCB2086A for ; Thu, 3 Oct 2019 08:55:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1ABCB2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE0B16B0005; Thu, 3 Oct 2019 04:55:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A90046B0006; Thu, 3 Oct 2019 04:55:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97EB36B0007; Thu, 3 Oct 2019 04:55:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 7A21C6B0005 for ; Thu, 3 Oct 2019 04:55:36 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 021F08E63 for ; Thu, 3 Oct 2019 08:55:36 +0000 (UTC) X-FDA: 76001865072.23.cakes59_87dfe8712075b X-HE-Tag: cakes59_87dfe8712075b X-Filterd-Recvd-Size: 2627 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Oct 2019 08:55:33 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E756128; Thu, 3 Oct 2019 01:55:32 -0700 (PDT) Received: from arrakis.emea.arm.com (unknown [10.1.196.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E50A63F739; Thu, 3 Oct 2019 01:55:30 -0700 (PDT) Date: Thu, 3 Oct 2019 09:55:28 +0100 From: Catalin Marinas To: Mark Salyzyn Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Andrew Morton , Yue Hu , Mike Rapoport , Will Deacon , Thomas Gleixner , Ryohei Suzuki , Doug Berger , Andrey Konovalov , Peng Fan , linux-mm@kvack.org, Christoph Hellwig , Robin Murphy Subject: Re: [PATCH] mm: export cma alloc and release Message-ID: <20191003085528.GB21629@arrakis.emea.arm.com> References: <20191002212257.196849-1-salyzyn@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191002212257.196849-1-salyzyn@android.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 02, 2019 at 02:22:48PM -0700, Mark Salyzyn wrote: > Some drivers can not be turned into a module without cma_alloc and > cma_release exported. Examples include ion, and we also found some > out of tree infiniband and camera drivers. > > Signed-off-by: Mark Salyzyn > Cc: kernel-team@android.com > Cc: linux-kernel@vger.kernel.org > --- > mm/cma.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/cma.c b/mm/cma.c > index 7fe0b8356775..65d830eea3b1 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -500,6 +500,7 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, > pr_debug("%s(): returned %p\n", __func__, page); > return page; > } > +EXPORT_SYMBOL_GPL(cma_alloc); > > /** > * cma_release() - release allocated pages > @@ -533,6 +534,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count) > > return true; > } > +EXPORT_SYMBOL_GPL(cma_release); Aren't drivers supposed to use the DMA API for such allocations rather than invoking cma_*() directly? -- Catalin