From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA28C35280 for ; Wed, 2 Oct 2019 13:32:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0136820842 for ; Wed, 2 Oct 2019 13:32:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0136820842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8A1816B0005; Wed, 2 Oct 2019 09:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8525C6B0006; Wed, 2 Oct 2019 09:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 768A56B000D; Wed, 2 Oct 2019 09:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 55DFF6B0005 for ; Wed, 2 Oct 2019 09:32:30 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id DE6F3181AC9AE for ; Wed, 2 Oct 2019 13:32:29 +0000 (UTC) X-FDA: 75998934018.15.scent89_159c558fdaa57 X-HE-Tag: scent89_159c558fdaa57 X-Filterd-Recvd-Size: 1475 Received: from mail3-162.sinamail.sina.com.cn (mail3-162.sinamail.sina.com.cn [202.108.3.162]) by imf38.hostedemail.com (Postfix) with SMTP for ; Wed, 2 Oct 2019 13:32:28 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([124.64.2.167]) by sina.com with ESMTP id 5D94A6E600024974; Wed, 2 Oct 2019 21:32:25 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 87410349284469 From: Hillf Danton To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/15] iomap: Support large pages Date: Wed, 2 Oct 2019 21:32:11 +0800 Message-Id: <20191002133211.15696-1-hdanton@sina.com> In-Reply-To: <20190925005214.27240-1-willy@infradead.org> References: <20190925005214.27240-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000652, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle) >=20 > @@ -1415,6 +1415,8 @@ static inline void clear_page_pfmemalloc(struct p= age *page) > extern void pagefault_out_of_memory(void); > =20 > #define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK) With the above define, the page_offset function is not named as badly as 03/15 claims. > +#define offset_in_this_page(page, p) \ > + ((unsigned long)(p) & (page_size(page) - 1)) What if Ted will post a rfc with offset_in_that_page defined next week?