From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6897C35280 for ; Wed, 2 Oct 2019 10:35:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9AF63218DE for ; Wed, 2 Oct 2019 10:35:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AF63218DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF5AA6B0005; Wed, 2 Oct 2019 06:35:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECB446B0006; Wed, 2 Oct 2019 06:35:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE1B76B0007; Wed, 2 Oct 2019 06:35:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id BC8616B0005 for ; Wed, 2 Oct 2019 06:35:17 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 2D21B181AC9B4 for ; Wed, 2 Oct 2019 10:35:17 +0000 (UTC) X-FDA: 75998487474.10.steel48_4b34543851c06 X-HE-Tag: steel48_4b34543851c06 X-Filterd-Recvd-Size: 2829 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Oct 2019 10:35:16 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 33B85B028; Wed, 2 Oct 2019 10:35:15 +0000 (UTC) Date: Wed, 2 Oct 2019 12:34:22 +0200 From: Michal Hocko To: David Rientjes Cc: Vlastimil Babka , Linus Torvalds , Andrea Arcangeli , Andrew Morton , Mel Gorman , "Kirill A. Shutemov" , Linux Kernel Mailing List , Linux-MM Subject: Re: [patch for-5.3 0/4] revert immediate fallback to remote hugepages Message-ID: <20191002103422.GJ15624@dhcp22.suse.cz> References: <20190909193020.GD2063@dhcp22.suse.cz> <20190925070817.GH23050@dhcp22.suse.cz> <20190927074803.GB26848@dhcp22.suse.cz> <20190930112817.GC15942@dhcp22.suse.cz> <20191001054343.GA15624@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 01-10-19 23:54:14, Vlastimil Babka wrote: > On 10/1/19 10:31 PM, David Rientjes wrote: [...] > > If > > hugetlb wants to stress this to the fullest extent possible, it already > > appropriately uses __GFP_RETRY_MAYFAIL. > > Which doesn't work anymore right now, and should again after this patch. I didn't get to fully digest the patch Vlastimil is proposing. (Ab)using __GFP_NORETRY is quite subtle but it is already in place with some explanation and a reference to THPs. So while I am not really happy it is at least something you can reason about. b39d0ee2632d ("mm, page_alloc: avoid expensive reclaim when compaction may not succeed") on the other hand has added a much more wider change which has clearly broken hugetlb and any __GFP_RETRY_MAYFAIL user of pageblock_order sized allocations. And that is much worse and something I was pointing at during the review and those concerns were never really addressed before merging. In any case this is something to be fixed ASAP. Do you have any better proposa? I do not assume you would be proposing yet another revert. -- Michal Hocko SUSE Labs