From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89ED2C388F3 for ; Tue, 1 Oct 2019 11:52:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 49E7D21920 for ; Tue, 1 Oct 2019 11:52:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="Efj+B4nT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49E7D21920 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF9F48E0006; Tue, 1 Oct 2019 07:52:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E84018E0001; Tue, 1 Oct 2019 07:52:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D71D68E0006; Tue, 1 Oct 2019 07:52:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id B352B8E0001 for ; Tue, 1 Oct 2019 07:52:41 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 5CA5C181AC9AE for ; Tue, 1 Oct 2019 11:52:41 +0000 (UTC) X-FDA: 75995053722.18.worm18_6ebcf228f403b X-HE-Tag: worm18_6ebcf228f403b X-Filterd-Recvd-Size: 4554 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Oct 2019 11:52:40 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id a15so11617784edt.6 for ; Tue, 01 Oct 2019 04:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jcFbftEjpta2y13GA3RqR5AgEFWor73R7GJxlkXb1DY=; b=Efj+B4nT92PjxgLdwaAbikzCcl7RsoyXjmBuG3TdB5B+wVU1va5i6kHvlgx3TYSiq5 P7Oehmi5qiapBr6TjX1oe+MXono1XYg96rgVu6HmWVBbiWucafeqkQRpbEEnLxBopMff pJMUxzc11m0vOZ2GOVy4XXg0GYeqeV43xGTWt+3/mqaiQSTXRqH+WdiTCc6YkFL1q/mv bo5RKnIp3WAEPuh0dSKZc5Ep/5saVyKEnJzInVAMIlBlZFFAlHmu3G7RHUO8e6AcBk2g HlXneZzHgrH4ZeIJKOaiHIM+emYZH3LxW7dgQ32wRpjgqItJjCS2N6qG4xv/e7S+S0km QGbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jcFbftEjpta2y13GA3RqR5AgEFWor73R7GJxlkXb1DY=; b=YxHTP+QtypoDKtzfvLONcSIgH4LXiBKt53psJavSzzL+x5h+hjFWysy12+vrfnCvdr ldJoKjfNQfUKRc16XPVSII0+6XyPjcmd8LFnIfDZnoCc8teeUj7juaniAyQlcA4fwGFO pCSvNtANEFb7MiBD0ebIE2SshA+d8kDNKtWdaIn8kn0bYj1wzyf7FtPQYeEtgE9YRPxI sy96HMptHaIsaZNPsgovCRI2dveOUzf3CQHW5w0Fg9F93d2BIFrxBzJ/jAtr9dDo/2tt 5gHIWgW4krRJ/1vlpph8N3golArsx0OwuH2LsJtbHWgbKCZBIw12RUnd94CMVXq1drNX W+wA== X-Gm-Message-State: APjAAAXz/XocGBgi/Hw6sYoIBg/6N4n3FsuNv+G1bs2xpwNqERYj/39c nsN1iy8D/qyHCdG3lgWZz+kYYJPQMcc= X-Google-Smtp-Source: APXvYqw/w4WE63OqtmSARVsxFLPOqJjSYs9OcZT2cvZ9KcJU5kG1OZtYa8IosMjoi8SZuiyc5ZXX/w== X-Received: by 2002:aa7:d995:: with SMTP id u21mr25117039eds.271.1569930759583; Tue, 01 Oct 2019 04:52:39 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id f36sm3091085ede.28.2019.10.01.04.52.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 04:52:38 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 925F2102FB8; Tue, 1 Oct 2019 14:52:39 +0300 (+03) Date: Tue, 1 Oct 2019 14:52:39 +0300 From: "Kirill A. Shutemov" To: Ralph Campbell Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" , Andrew Morton Subject: Re: [PATCH] mm/thp: make set_huge_zero_page() return void Message-ID: <20191001115239.dqodyji3r32zjkea@box> References: <20190930195528.32553-1-rcampbell@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190930195528.32553-1-rcampbell@nvidia.com> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 30, 2019 at 12:55:28PM -0700, Ralph Campbell wrote: > The return value from set_huge_zero_page() is never checked so simplify > the code by making it return void. > > Signed-off-by: Ralph Campbell > --- > mm/huge_memory.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index c5cb6dcd6c69..6cf0ee65538d 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -686,20 +686,18 @@ static inline gfp_t alloc_hugepage_direct_gfpmask(struct vm_area_struct *vma) > } > > /* Caller must hold page table lock. */ > -static bool set_huge_zero_page(pgtable_t pgtable, struct mm_struct *mm, > +static void set_huge_zero_page(pgtable_t pgtable, struct mm_struct *mm, > struct vm_area_struct *vma, unsigned long haddr, pmd_t *pmd, > struct page *zero_page) > { > pmd_t entry; > - if (!pmd_none(*pmd)) > - return false; > + Wat? So you just bindly overwrite whatever is there? NAK. > entry = mk_pmd(zero_page, vma->vm_page_prot); > entry = pmd_mkhuge(entry); > if (pgtable) > pgtable_trans_huge_deposit(mm, pmd, pgtable); > set_pmd_at(mm, haddr, pmd, entry); > mm_inc_nr_ptes(mm); > - return true; > } > > vm_fault_t do_huge_pmd_anonymous_page(struct vm_fault *vmf) > -- > 2.20.1 > > -- Kirill A. Shutemov