From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB92EECE589 for ; Tue, 1 Oct 2019 10:42:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FEDE21906 for ; Tue, 1 Oct 2019 10:42:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="yyrFnMA4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FEDE21906 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 239868E0006; Tue, 1 Oct 2019 06:42:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C0698E0001; Tue, 1 Oct 2019 06:42:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08FFE8E0006; Tue, 1 Oct 2019 06:42:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id D67348E0001 for ; Tue, 1 Oct 2019 06:42:22 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 475D82C14 for ; Tue, 1 Oct 2019 10:42:22 +0000 (UTC) X-FDA: 75994876524.26.money37_4edb0a4f2b148 X-HE-Tag: money37_4edb0a4f2b148 X-Filterd-Recvd-Size: 3944 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Oct 2019 10:42:21 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id v8so11466401eds.2 for ; Tue, 01 Oct 2019 03:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=K1jPj14nxpAoVvF1PZlHFLbTjJlXvJfGDzQ5Wzyv9Ek=; b=yyrFnMA4aY10KseW9DWUcxSYaja2Uswf8aTlSgS6v/hJw/GxX84hrTGd79zrlgjilm FzPrD4EROIlhtcwsK6Q8zt1epjMS5KM2UPNklRGjQYM+JrVTZ4XaJj/446qgdyz7uU6i fcEZXAPKo38jdbVUX0LXncAADgzJySy7YJuRnaR3rcxi/OQUmJhpq7yU+xwwB80VIVwz 1Z1yc3qfe2Fiq+RpKLM2UsVVvTJcmsQMsxnoqXc0HPUvoECnZgJX9GnrayrsHJPTQZNr Wkn95IGQz6w0b8QIdGnQ1FMQms1Q6NxW1g4x20fOlki8qx3i/yeshnbt0zEg0NWKziui Ttzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=K1jPj14nxpAoVvF1PZlHFLbTjJlXvJfGDzQ5Wzyv9Ek=; b=MiL7wz+5lfB9/qknAf5VN14bRF4VzPWf4iLHu4L6XNRKTFVHipAOGl+Zyd5KcJcFDc 0DIRK5pTp1svcDj7M06tgSJ5fV6WhL86XE/wEwyY5Z6bRI4PsVGahQScz9FpBzlwe5pJ yIci6NuYeesHabyf+Sd/Bgl7LL7qxCVLZpOgsefqQiuRyAQhJR9Z02F8De2bEk90WT6z 37Pmz/Kle1CjizifZeJBKWjSpWRoAFVd5LgpcS5UFLC0Gy95pBcmhJ4lMyTLfqsYvf8C UMYTY9TNDH4QXl03Axy1YWyth0lFngLX0ioTMvdvZAVL7DuQCCr6mrxdZ5YmUQ/5tRI6 sBJA== X-Gm-Message-State: APjAAAXq2Cwox7grIE8EIdPswFxcqzxleMRVVwplUX2BdSla5KZqJRmK 8UPB+zFhAbG4aI5RQ2qrJr+chg== X-Google-Smtp-Source: APXvYqyAm6+9hgtwYZ6sZEL5nFAwqNn1WDZ9BjiinNKVy+eFRejDSKRUOOx14gRU9eSGhSRtDXGILg== X-Received: by 2002:a17:906:7fda:: with SMTP id r26mr23780727ejs.170.1569926540535; Tue, 01 Oct 2019 03:42:20 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id a3sm3041116edk.51.2019.10.01.03.42.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 03:42:19 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 73B25102FB8; Tue, 1 Oct 2019 13:42:20 +0300 (+03) Date: Tue, 1 Oct 2019 13:42:20 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, William Kucharski Subject: Re: [PATCH 13/15] mm: Add a huge page fault handler for files Message-ID: <20191001104220.zhjcpdi6oaxl5un5@box> References: <20190925005214.27240-1-willy@infradead.org> <20190925005214.27240-14-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190925005214.27240-14-willy@infradead.org> User-Agent: NeoMutt/20180716 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 24, 2019 at 05:52:12PM -0700, Matthew Wilcox wrote: > From: William Kucharski >=20 > Add filemap_huge_fault() to attempt to satisfy page > faults on memory-mapped read-only text pages using THP when possible. >=20 > Signed-off-by: William Kucharski > [rebased on top of mm prep patches -- Matthew] > Signed-off-by: Matthew Wilcox (Oracle) As we discuss before, I think it's wrong direction to separate ->fault() from ->huge_fault(). If ->fault() would return a huge page alloc_set_pte(= ) will do The Right Thing=E2=84=A2. --=20 Kirill A. Shutemov