From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B2DC32792 for ; Mon, 30 Sep 2019 11:04:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A1DEA21855 for ; Mon, 30 Sep 2019 11:04:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="X42lMnnx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1DEA21855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4B0AC6B0006; Mon, 30 Sep 2019 07:04:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 462606B0007; Mon, 30 Sep 2019 07:04:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 353B96B0008; Mon, 30 Sep 2019 07:04:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 154E66B0006 for ; Mon, 30 Sep 2019 07:04:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id AED7975A9 for ; Mon, 30 Sep 2019 11:04:37 +0000 (UTC) X-FDA: 75991303794.11.bun92_4574b6535894f X-HE-Tag: bun92_4574b6535894f X-Filterd-Recvd-Size: 3580 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Sep 2019 11:04:37 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id t3so8193055edw.13 for ; Mon, 30 Sep 2019 04:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3k6dAmBoQBVj4O9ENLrppdo0K0+1hJqkhh7Nc8T2PGg=; b=X42lMnnx21hsZzUbXK4K09UEcg8JN5kUGkiMXkCDlre/ah2Vjy5ukUfyiQJ9TL4BTr wg0eMRd45KG/JAWicVc4DcRa5et4YZVgWbxDA6W780jF6mXEvBfN9R1Z+cdjsz1AgLQU C+Qlf7rbRk5HL+th7zt1WS+4nd9UMV6sW08hDwhpPubs00OvuT8UcGU+Yi/C07WIuoQ8 fFfmYHnlI+YOYuBE+GJXTMr7AYNZPBT4y6ZgM1U1hYRWlhtKdJqS1prucSEPfByOd0gY FV7ztb9DXRvWYblRLvC3rDSEi3u8ZIZqj2cCGtoi34IBQ24x5S661NlVcVJMP5Sq2z7/ Wwsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3k6dAmBoQBVj4O9ENLrppdo0K0+1hJqkhh7Nc8T2PGg=; b=Ea+tjSPcErwr54CimExvnwaPrc9ct482V5r116rZDjD5MO7HBONTabFDPjjnywbcrF fnc52Ys1pnaqRACZz83Nqt0ZHdAyf4nEEKu436Zc2s4GWTzzv04oFIPVUGrAKDXeUKB0 vDP36tN228M1xL/ScJ0aXnrMoiIyTn9Ms0Hd/UA1o2ko45p0VPREd+AgxB5EwTnjGQuL J2ukvDZEK26LzBMUuhaWwe/yBngK5LwOpvLwOiDI6lcZzk45zQP+L+X8QD8DFKzIPLjK DB1KsZFmk6PlXNTztJGbIW3zdNB7ix7w3J2OvhjVmKCBzDECemFxR7CocHFcTBKGrmPG Kl0Q== X-Gm-Message-State: APjAAAWlAPJTK+2A4JI+Clm3wg7mtgbtSGkqHPVgoFXdMPrV/Wvj/G7z ophFVj7fBYdJBxzlxQTsNjWwVg== X-Google-Smtp-Source: APXvYqy2PIFBcDe67nBH9RLsiz23AOO3Np3ANSt8QomqGwKLLjduWHQhucN8Jl+fY1ZvKnMFismhaw== X-Received: by 2002:a05:6402:3d2:: with SMTP id t18mr18496910edw.136.1569841475915; Mon, 30 Sep 2019 04:04:35 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id 4sm1392570ejm.47.2019.09.30.04.04.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Sep 2019 04:04:35 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 633301020E6; Mon, 30 Sep 2019 14:04:34 +0300 (+03) Date: Mon, 30 Sep 2019 14:04:34 +0300 From: "Kirill A. Shutemov" To: Qian Cai Cc: akpm@linux-foundation.org, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare() Message-ID: <20190930110434.5k47w7xfvkjcohkp@box> References: <1569613623-16820-1-git-send-email-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1569613623-16820-1-git-send-email-cai@lca.pw> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.023985, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 27, 2019 at 03:47:03PM -0400, Qian Cai wrote: > On architectures like s390, arch_free_page() could mark the page unused > (set_page_unused()) and any access later would trigger a kernel panic. > Fix it by moving arch_free_page() after all possible accessing calls. Looks like Power also uses the hook. Have you check that this patch will not affect Power? -- Kirill A. Shutemov