From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86C77C4360C for ; Sun, 29 Sep 2019 09:17:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 396EA207FA for ; Sun, 29 Sep 2019 09:17:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 396EA207FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 960C46B0003; Sun, 29 Sep 2019 05:17:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 911066B0005; Sun, 29 Sep 2019 05:17:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FEF76B0006; Sun, 29 Sep 2019 05:17:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id 57D4F6B0003 for ; Sun, 29 Sep 2019 05:17:02 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id EE57755F8F for ; Sun, 29 Sep 2019 09:17:01 +0000 (UTC) X-FDA: 75987403842.09.soap68_5a5e7ac6b002b X-HE-Tag: soap68_5a5e7ac6b002b X-Filterd-Recvd-Size: 3890 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Sun, 29 Sep 2019 09:17:00 +0000 (UTC) Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A5913688E for ; Sun, 29 Sep 2019 09:16:59 +0000 (UTC) Received: by mail-pf1-f197.google.com with SMTP id u12so5399497pfn.19 for ; Sun, 29 Sep 2019 02:16:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P6VGb1/+Qfi2DI180P7/GtJ06kqrwHJMEdoHnmE9Gwg=; b=ND+M9dIpbXuekAQOv92oR7GGKtQEmDXU+aCv8dPEbrp6ChLfz/Cpmb9L6V7cN/wGxM p0o9fIF65yjdygAjfoOHofBn4LR5y5E0wiAU2EAcEkLhjvq8Y/6BZAp37BplX1kUW5Jk BMtwTAC9fQXpwlXkdywHBR6P9uC6Ms/m8WDtmdZlV2+NVCWtNcp5mipaDBXkmkinG5AO rKTjQGTIIUGnLOh54peDJv3nNV10tpLMNlVkJn/LcwwEaBcm+0dYGH7inaDSAzGb5BpK mKYOyc5FAbzFm8JliinlkEYVcD5ms0TUiKxmhz3onydVD8TqQS15bL0LNYfhru0FLILK Vc3Q== X-Gm-Message-State: APjAAAUiS7oejCUzpX0K4LzIdqraJq8pF5g/fk/VZOku7USS7zFEm7qQ U5of7s8ggh8aJVhzAOUCwatkG6iqbZO97HrPtBC70RiM157G/LD3bmwN9z4hdREnGbmPHnNDS4t JMo+0HBeip7U= X-Received: by 2002:a62:cf82:: with SMTP id b124mr14756302pfg.159.1569748618778; Sun, 29 Sep 2019 02:16:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqyXjYVu6huJ3qsbdp5C5bVuAZKEs+4sotE2dY/cWXMPEirvmKQ1SfQ1LlVODij9fedALcPlNA== X-Received: by 2002:a62:cf82:: with SMTP id b124mr14756272pfg.159.1569748618540; Sun, 29 Sep 2019 02:16:58 -0700 (PDT) Received: from xz-x1 ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id u11sm12215952pgb.75.2019.09.29.02.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Sep 2019 02:16:56 -0700 (PDT) Date: Sun, 29 Sep 2019 17:16:41 +0800 From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Hugh Dickins , Maya Gokhale , Jerome Glisse , Pavel Emelyanov , Johannes Weiner , Martin Cracauer , Matthew Wilcox , Shaohua Li , Marty McFadden , Andrea Arcangeli , Mike Kravetz , Denis Plotnikov , Mike Rapoport , Linus Torvalds , Mel Gorman , "Kirill A . Shutemov" , "Dr . David Alan Gilbert" Subject: Re: [PATCH v5 16/16] mm/userfaultfd: Honor FAULT_FLAG_KILLABLE in fault path Message-ID: <20190929091641.GA8642@xz-x1> References: <20190926093904.5090-1-peterx@redhat.com> <20190926093904.5090-17-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190926093904.5090-17-peterx@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 26, 2019 at 05:39:04PM +0800, Peter Xu wrote: > @@ -490,8 +512,7 @@ vm_fault_t handle_userfault(struct vm_fault *vmf, unsigned long reason) > up_read(&mm->mmap_sem); > > if (likely(must_wait && !READ_ONCE(ctx->released) && > - (return_to_userland ? !signal_pending(current) : > - !fatal_signal_pending(current)))) { > + userfaultfd_signal_pending(vmf->flags))) { Sorry, here it should be "!userfaultfd_signal_pending(vmf->flags)". -- Peter Xu