From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F6EC4360C for ; Sat, 28 Sep 2019 22:04:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EDC620880 for ; Sat, 28 Sep 2019 22:04:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Scf4bwAi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EDC620880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 983B86B0003; Sat, 28 Sep 2019 18:04:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90E306B0005; Sat, 28 Sep 2019 18:04:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8223E8E0001; Sat, 28 Sep 2019 18:04:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 59FA76B0003 for ; Sat, 28 Sep 2019 18:04:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id EB35A181AC9BA for ; Sat, 28 Sep 2019 22:04:12 +0000 (UTC) X-FDA: 75985708344.29.glass18_24c10f6c9ae38 X-HE-Tag: glass18_24c10f6c9ae38 X-Filterd-Recvd-Size: 3231 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Sat, 28 Sep 2019 22:04:12 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC92F20866; Sat, 28 Sep 2019 22:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569708251; bh=+LR3RvDm+2ZImZYU0glSfuRvJ341Rv5LciFQr6Cy6wA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Scf4bwAi5HaX4X8cVyqnzFCGblAgIqSzzPiGp8HzS33jbEOYbplOkEUjSBucQxE0m e2AiKx++r8+hyzaKXCbkw8k0wMyrCtVs4R+ZPbWEKmA7tJF+d4hty+Hy7Bl5PM47RA WIfNUHmdF3xcenKQzW66jKe2p5qc+yrXyECXfxbk= Date: Sat, 28 Sep 2019 15:04:10 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Dan Carpenter , Greg Kroah-Hartman , Andy Shevchenko , tglx@linutronix.de, Enrico Weigelt , Kate Stewart , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm, vmpressure: Fix a signedness bug in vmpressure_register_event() Message-Id: <20190928150410.5964a7935ca1b3cb47a2ae76@linux-foundation.org> In-Reply-To: <20190928214702.GA30382@bombadil.infradead.org> References: <20190925110449.GO3264@mwanda> <20190928142356.932cff0ad6c17f4a18edc80f@linux-foundation.org> <20190928214702.GA30382@bombadil.infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 28 Sep 2019 14:47:02 -0700 Matthew Wilcox wrote: > On Sat, Sep 28, 2019 at 02:23:56PM -0700, Andrew Morton wrote: > > How about doing it this way? Only copy the int to the enum once we > > know it's within range? > > This will return a positive integer on success instead of 0. We need: > > mutex_unlock(&vmpr->events_lock); > + ret = 0; > out: > > with that, > > Reviewed-by: Matthew Wilcox (Oracle) > > How about further adding ... > > + * Return: 0 on success, -ENOMEM on memory failure or -EINVAL if @args could > + * not be parsed. Cool. --- a/mm/vmpressure.c~mm-vmpressure-fix-a-signedness-bug-in-vmpressure_register_event-fix-fix +++ a/mm/vmpressure.c @@ -355,6 +355,9 @@ void vmpressure_prio(gfp_t gfp, struct m * "hierarchy" or "local"). * * To be used as memcg event method. + * + * Return: 0 on success, -ENOMEM on memory failure or -EINVAL if @args could + * not be parsed. */ int vmpressure_register_event(struct mem_cgroup *memcg, struct eventfd_ctx *eventfd, const char *args) @@ -402,6 +405,7 @@ int vmpressure_register_event(struct mem mutex_lock(&vmpr->events_lock); list_add(&ev->node, &vmpr->events); mutex_unlock(&vmpr->events_lock); + ret = 0; out: kfree(spec_orig); return ret; _