linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kaitao Cheng <pilgrimtao@gmail.com>
To: akpm@linux-foundation.org
Cc: sashal@kernel.org, mhocko@suse.com, osalvador@suse.de,
	mgorman@techsingularity.net, rppt@linux.ibm.com,
	dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com,
	pavel.tatashin@microsoft.com, glider@google.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Kaitao Cheng <pilgrimtao@gmail.com>,
	Muchun Song <smuchun@gmail.com>
Subject: [PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists()
Date: Sat, 28 Sep 2019 00:14:16 +0800	[thread overview]
Message-ID: <20190927161416.62293-1-pilgrimtao@gmail.com> (raw)

There is no need to make the 'node_order' variable static
since new value always be assigned before use it.

Signed-off-by: Kaitao Cheng <pilgrimtao@gmail.com>
Signed-off-by: Muchun Song <smuchun@gmail.com>
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 3334a769eb91..c473c304d09f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5597,7 +5597,7 @@ static void build_thisnode_zonelists(pg_data_t *pgdat)
 
 static void build_zonelists(pg_data_t *pgdat)
 {
-	static int node_order[MAX_NUMNODES];
+	int node_order[MAX_NUMNODES];
 	int node, load, nr_nodes = 0;
 	nodemask_t used_mask;
 	int local_node, prev_node;
-- 
2.20.1



             reply	other threads:[~2019-09-27 16:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 16:14 Kaitao Cheng [this message]
2019-09-27 19:32 ` Dan Williams
2019-10-08 19:06 ` Christopher Lameter
2019-10-08 19:21   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190927161416.62293-1-pilgrimtao@gmail.com \
    --to=pilgrimtao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=glider@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=pavel.tatashin@microsoft.com \
    --cc=rppt@linux.ibm.com \
    --cc=sashal@kernel.org \
    --cc=smuchun@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox