From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F172DC432C1 for ; Wed, 25 Sep 2019 07:32:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A2166217F4 for ; Wed, 25 Sep 2019 07:32:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2166217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4E3036B026B; Wed, 25 Sep 2019 03:32:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 493F46B026C; Wed, 25 Sep 2019 03:32:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35A756B026D; Wed, 25 Sep 2019 03:32:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 0E0EE6B026B for ; Wed, 25 Sep 2019 03:32:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id B525740C0 for ; Wed, 25 Sep 2019 07:32:51 +0000 (UTC) X-FDA: 75972626142.01.park55_702fcd1fc5d0a X-HE-Tag: park55_702fcd1fc5d0a X-Filterd-Recvd-Size: 12534 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Sep 2019 07:32:50 +0000 (UTC) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x8P7RxdO130330 for ; Wed, 25 Sep 2019 03:32:49 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2v81bpwu5y-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 25 Sep 2019 03:32:48 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Sep 2019 08:32:46 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 25 Sep 2019 08:32:43 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x8P7WESd37945808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Sep 2019 07:32:15 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3C2664C04E; Wed, 25 Sep 2019 07:32:42 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 62F024C046; Wed, 25 Sep 2019 07:32:41 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.8.153]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 25 Sep 2019 07:32:41 +0000 (GMT) Date: Wed, 25 Sep 2019 10:32:39 +0300 From: Mike Rapoport To: Yunfeng Ye Cc: Wei Yang , akpm@linux-foundation.org, osalvador@suse.de, mhocko@suse.co, dan.j.williams@intel.com, david@redhat.com, cai@lca.pw, linux-mm@kvack.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V3] mm: Support memblock alloc on the exact node for sparse_buffer_init() References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19092507-0028-0000-0000-000003A23C9F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19092507-0029-0000-0000-00002464552A Message-Id: <20190925073239.GD1857@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-25_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909250076 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 25, 2019 at 03:18:43PM +0800, Yunfeng Ye wrote: > sparse_buffer_init() use memblock_alloc_try_nid_raw() to allocate memory > for page management structure, if memory allocation fails from specified > node, it will fall back to allocate from other nodes. > > Normally, the page management structure will not exceed 2% of the total > memory, but a large continuous block of allocation is needed. In most > cases, memory allocation from the specified node will success always, > but a node memory become highly fragmented will fail. we expect to > allocate memory base section rather than by allocating a large block of > memory from other NUMA nodes > > Add memblock_alloc_exact_nid_raw() for this situation, which allocate > boot memory block on the exact node. If a large contiguous block memory > allocate fail in sparse_buffer_init(), it will fall back to allocate > small block memory base section. > > Signed-off-by: Yunfeng Ye One nit below, otherwise Reviewed-by: Mike Rapoport > --- > v2 -> v3: > - use "bool exact_nid" instead of "int need_exact_nid" > - remove the comment "without panicking" > > v1 -> v2: > - use memblock_alloc_exact_nid_raw() rather than using a flag > > include/linux/memblock.h | 3 +++ > mm/memblock.c | 65 ++++++++++++++++++++++++++++++++++++++++-------- > mm/sparse.c | 2 +- > 3 files changed, 58 insertions(+), 12 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index f491690..b38bbef 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -358,6 +358,9 @@ static inline phys_addr_t memblock_phys_alloc(phys_addr_t size, > MEMBLOCK_ALLOC_ACCESSIBLE); > } > > +void *memblock_alloc_exact_nid_raw(phys_addr_t size, phys_addr_t align, > + phys_addr_t min_addr, phys_addr_t max_addr, > + int nid); > void *memblock_alloc_try_nid_raw(phys_addr_t size, phys_addr_t align, > phys_addr_t min_addr, phys_addr_t max_addr, > int nid); > diff --git a/mm/memblock.c b/mm/memblock.c > index 7d4f61a..0de9d83 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1323,12 +1323,13 @@ __next_mem_pfn_range_in_zone(u64 *idx, struct zone *zone, > * @start: the lower bound of the memory region to allocate (phys address) > * @end: the upper bound of the memory region to allocate (phys address) > * @nid: nid of the free area to find, %NUMA_NO_NODE for any node > + * @exact_nid: control the allocation fall back to other nodes > * > * The allocation is performed from memory region limited by > * memblock.current_limit if @max_addr == %MEMBLOCK_ALLOC_ACCESSIBLE. > * > - * If the specified node can not hold the requested memory the > - * allocation falls back to any node in the system > + * If the specified node can not hold the requested memory and @exact_nid > + * is zero, the allocation falls back to any node in the system ^ is false ;-) > * > * For systems with memory mirroring, the allocation is attempted first > * from the regions with mirroring enabled and then retried from any > @@ -1342,7 +1343,8 @@ __next_mem_pfn_range_in_zone(u64 *idx, struct zone *zone, > */ > static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > phys_addr_t align, phys_addr_t start, > - phys_addr_t end, int nid) > + phys_addr_t end, int nid, > + bool exact_nid) > { > enum memblock_flags flags = choose_memblock_flags(); > phys_addr_t found; > @@ -1365,7 +1367,7 @@ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > if (found && !memblock_reserve(found, size)) > goto done; > > - if (nid != NUMA_NO_NODE) { > + if (nid != NUMA_NO_NODE && !exact_nid) { > found = memblock_find_in_range_node(size, align, start, > end, NUMA_NO_NODE, > flags); > @@ -1413,7 +1415,8 @@ phys_addr_t __init memblock_phys_alloc_range(phys_addr_t size, > phys_addr_t start, > phys_addr_t end) > { > - return memblock_alloc_range_nid(size, align, start, end, NUMA_NO_NODE); > + return memblock_alloc_range_nid(size, align, start, end, NUMA_NO_NODE, > + false); > } > > /** > @@ -1432,7 +1435,7 @@ phys_addr_t __init memblock_phys_alloc_range(phys_addr_t size, > phys_addr_t __init memblock_phys_alloc_try_nid(phys_addr_t size, phys_addr_t align, int nid) > { > return memblock_alloc_range_nid(size, align, 0, > - MEMBLOCK_ALLOC_ACCESSIBLE, nid); > + MEMBLOCK_ALLOC_ACCESSIBLE, nid, false); > } > > /** > @@ -1442,6 +1445,7 @@ phys_addr_t __init memblock_phys_alloc_try_nid(phys_addr_t size, phys_addr_t ali > * @min_addr: the lower bound of the memory region to allocate (phys address) > * @max_addr: the upper bound of the memory region to allocate (phys address) > * @nid: nid of the free area to find, %NUMA_NO_NODE for any node > + * @exact_nid: control the allocation fall back to other nodes > * > * Allocates memory block using memblock_alloc_range_nid() and > * converts the returned physical address to virtual. > @@ -1457,7 +1461,7 @@ phys_addr_t __init memblock_phys_alloc_try_nid(phys_addr_t size, phys_addr_t ali > static void * __init memblock_alloc_internal( > phys_addr_t size, phys_addr_t align, > phys_addr_t min_addr, phys_addr_t max_addr, > - int nid) > + int nid, bool exact_nid) > { > phys_addr_t alloc; > > @@ -1469,11 +1473,13 @@ static void * __init memblock_alloc_internal( > if (WARN_ON_ONCE(slab_is_available())) > return kzalloc_node(size, GFP_NOWAIT, nid); > > - alloc = memblock_alloc_range_nid(size, align, min_addr, max_addr, nid); > + alloc = memblock_alloc_range_nid(size, align, min_addr, max_addr, nid, > + exact_nid); > > /* retry allocation without lower limit */ > if (!alloc && min_addr) > - alloc = memblock_alloc_range_nid(size, align, 0, max_addr, nid); > + alloc = memblock_alloc_range_nid(size, align, 0, max_addr, nid, > + exact_nid); > > if (!alloc) > return NULL; > @@ -1482,6 +1488,43 @@ static void * __init memblock_alloc_internal( > } > > /** > + * memblock_alloc_exact_nid_raw - allocate boot memory block on the exact node > + * without zeroing memory > + * @size: size of memory block to be allocated in bytes > + * @align: alignment of the region and block's size > + * @min_addr: the lower bound of the memory region from where the allocation > + * is preferred (phys address) > + * @max_addr: the upper bound of the memory region from where the allocation > + * is preferred (phys address), or %MEMBLOCK_ALLOC_ACCESSIBLE to > + * allocate only from memory limited by memblock.current_limit value > + * @nid: nid of the free area to find, %NUMA_NO_NODE for any node > + * > + * Public function, provides additional debug information (including caller > + * info), if enabled. Does not zero allocated memory. > + * > + * Return: > + * Virtual address of allocated memory block on success, NULL on failure. > + */ > +void * __init memblock_alloc_exact_nid_raw( > + phys_addr_t size, phys_addr_t align, > + phys_addr_t min_addr, phys_addr_t max_addr, > + int nid) > +{ > + void *ptr; > + > + memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=%pa max_addr=%pa %pS\n", > + __func__, (u64)size, (u64)align, nid, &min_addr, > + &max_addr, (void *)_RET_IP_); > + > + ptr = memblock_alloc_internal(size, align, > + min_addr, max_addr, nid, true); > + if (ptr && size > 0) > + page_init_poison(ptr, size); > + > + return ptr; > +} > + > +/** > * memblock_alloc_try_nid_raw - allocate boot memory block without zeroing > * memory and without panicking > * @size: size of memory block to be allocated in bytes > @@ -1512,7 +1555,7 @@ void * __init memblock_alloc_try_nid_raw( > &max_addr, (void *)_RET_IP_); > > ptr = memblock_alloc_internal(size, align, > - min_addr, max_addr, nid); > + min_addr, max_addr, nid, false); > if (ptr && size > 0) > page_init_poison(ptr, size); > > @@ -1547,7 +1590,7 @@ void * __init memblock_alloc_try_nid( > __func__, (u64)size, (u64)align, nid, &min_addr, > &max_addr, (void *)_RET_IP_); > ptr = memblock_alloc_internal(size, align, > - min_addr, max_addr, nid); > + min_addr, max_addr, nid, false); > if (ptr) > memset(ptr, 0, size); > > diff --git a/mm/sparse.c b/mm/sparse.c > index 72f010d..1a06471 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -475,7 +475,7 @@ static void __init sparse_buffer_init(unsigned long size, int nid) > phys_addr_t addr = __pa(MAX_DMA_ADDRESS); > WARN_ON(sparsemap_buf); /* forgot to call sparse_buffer_fini()? */ > sparsemap_buf = > - memblock_alloc_try_nid_raw(size, PAGE_SIZE, > + memblock_alloc_exact_nid_raw(size, PAGE_SIZE, > addr, > MEMBLOCK_ALLOC_ACCESSIBLE, nid); > sparsemap_buf_end = sparsemap_buf + size; > -- > 2.7.4 > -- Sincerely yours, Mike.