From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B26EC4320D for ; Mon, 23 Sep 2019 23:20:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E95D21D56 for ; Mon, 23 Sep 2019 23:20:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZGWYGBKA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E95D21D56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB5AA6B02B8; Mon, 23 Sep 2019 19:20:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A66146B02BE; Mon, 23 Sep 2019 19:20:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97CE56B02BF; Mon, 23 Sep 2019 19:20:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 76BCB6B02B8 for ; Mon, 23 Sep 2019 19:20:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id DFBD38243776 for ; Mon, 23 Sep 2019 23:20:22 +0000 (UTC) X-FDA: 75967756284.28.crush92_77ae4c5c1ee35 X-HE-Tag: crush92_77ae4c5c1ee35 X-Filterd-Recvd-Size: 4846 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Sep 2019 23:20:22 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id 4so5271pld.10 for ; Mon, 23 Sep 2019 16:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=CFATbYWeHQUWFhlXAsb5eUd2KlAcJsW24M+BNCgo4pA=; b=ZGWYGBKAmtffK0FtCjaNcaLo0NA0Vlf1+k36qISFiqOzW7qD7Ktu8p1dyxCDSnJ8wl likxB7pqfJ6F9y2MyiJGygBM/5glHRqiEnhpQjGoKUlohphI9+2+N4Gp4KxFmrkISrut j6BuTsfxl47+muQaAnnYpj7W3QbsXsjIoK6as= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CFATbYWeHQUWFhlXAsb5eUd2KlAcJsW24M+BNCgo4pA=; b=NWwxzUdnM0EYYAne1s+Iebh8d85fUs/UNkhsuSJoyAo4XsU7nPOlOdL1eb6IE5CnDb YrH2FatMDW+vx5qBR7T8aaeneGKwj75C3ZEilJm74R1K11CUuJdvVLm8z3CKp97gHUZt 7psp57UU+GjQmuJmwnP82qpXP1dFoOKpgd0yiDZQSTXf5lJriRLdE26iDOki8f1giz8x 3YT9JKGieaWM7q2yVsyzxbSqePho8OX066CtodLeBcm+WAExBjEZl75WKVdh1ok86RGt IEKhgiQK9/Cg6e2diOkUQ8sdXPDaxHLwavKs804selalcvYW0XUWOwQJXH1rBmnSPDR3 ezag== X-Gm-Message-State: APjAAAWv/HGeFRENDdFhpDhFWdIQ0FoaMp73CEFsZWa+KlEU6L4+jyGA yf7CaqpBOyR9QU3OrQLSXJyUBQ== X-Google-Smtp-Source: APXvYqxQ2fEtz7Xf+sUIEAmsivoBRkAga2yJdYTPaY+W0awe8f1IS/TdeGDNsTYe1cV+oCDn7hztow== X-Received: by 2002:a17:902:36c:: with SMTP id 99mr2227293pld.69.1569280821306; Mon, 23 Sep 2019 16:20:21 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u17sm11944927pgf.8.2019.09.23.16.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 16:20:20 -0700 (PDT) Date: Mon, 23 Sep 2019 16:20:19 -0700 From: Kees Cook To: David Hildenbrand Cc: Yi Wang , akpm@linux-foundation.org, dan.j.williams@intel.com, cai@lca.pw, linux-mm@kvack.org, linux-kernel@vger.kernel.org, osalvador@suse.de, mhocko@suse.com, rppt@linux.ibm.com, richardw.yang@linux.intel.com, xue.zhihong@zte.com.cn, up2wing@gmail.com, wang.liang82@zte.com.cn Subject: Re: [PATCH] mm: fix -Wmissing-prototypes warnings Message-ID: <201909231620.7C39AE91@keescook> References: <1566978161-7293-1-git-send-email-wang.yi59@zte.com.cn> <89532e1d-bc41-ce70-ae3c-d6073e5c3cd4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <89532e1d-bc41-ce70-ae3c-d6073e5c3cd4@redhat.com> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 09, 2019 at 09:52:40AM +0200, David Hildenbrand wrote: > On 28.08.19 09:42, Yi Wang wrote: > > We get two warnings when build kernel W=3D1: > > mm/shuffle.c:36:12: warning: no previous prototype for =E2=80=98shuff= le_show=E2=80=99 > > [-Wmissing-prototypes] > > mm/sparse.c:220:6: warning: no previous prototype for > > =E2=80=98subsection_mask_set=E2=80=99 [-Wmissing-prototypes] > >=20 > > Make the function static to fix this. > >=20 > > Signed-off-by: Yi Wang > > --- > > mm/shuffle.c | 2 +- > > mm/sparse.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/mm/shuffle.c b/mm/shuffle.c > > index 3ce1248..b3fe97f 100644 > > --- a/mm/shuffle.c > > +++ b/mm/shuffle.c > > @@ -33,7 +33,7 @@ __meminit void page_alloc_shuffle(enum mm_shuffle_c= tl ctl) > > } > > =20 > > static bool shuffle_param; > > -extern int shuffle_show(char *buffer, const struct kernel_param *kp) > > +static int shuffle_show(char *buffer, const struct kernel_param *kp) > > { > > return sprintf(buffer, "%c\n", test_bit(SHUFFLE_ENABLE, &shuffle_st= ate) > > ? 'Y' : 'N'); > > diff --git a/mm/sparse.c b/mm/sparse.c > > index 72f010d..49006dd 100644 > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -217,7 +217,7 @@ static inline unsigned long first_present_section= _nr(void) > > return next_present_section_nr(-1); > > } > > =20 > > -void subsection_mask_set(unsigned long *map, unsigned long pfn, > > +static void subsection_mask_set(unsigned long *map, unsigned long pf= n, > > unsigned long nr_pages) > > { > > int idx =3D subsection_map_index(pfn); > >=20 >=20 > Reviewed-by: David Hildenbrand Reviewed-by: Kees Cook Andrew, can you take this? --=20 Kees Cook