From: Baoquan He <bhe@redhat.com>
To: tj@kernel.org
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] memcg: Only record foreign writebacks with dirty pages when memcg is not disabled
Date: Mon, 23 Sep 2019 16:42:17 +0800 [thread overview]
Message-ID: <20190923084217.GA342@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20190923083030.6442-1-bhe@redhat.com>
On 09/23/19 at 04:30pm, Baoquan He wrote:
> ---
> include/linux/memcontrol.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index ad8f1a397ae4..fa53f9d51205 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1261,7 +1261,8 @@ void mem_cgroup_track_foreign_dirty_slowpath(struct page *page,
> static inline void mem_cgroup_track_foreign_dirty(struct page *page,
> struct bdi_writeback *wb)
> {
> - if (unlikely(&page->mem_cgroup->css != wb->memcg_css))
> + if (unlikely(&page->mem_cgroup->css != wb->memcg_css)
> + && !mem_cgroup_disabled())
Sorry, this is the draft patch I was testing. Later I think this
had better be moved into mem_cgroup_track_foreign_dirty_slowpath().
Not very sure about this. Will send a v2 to match the patch log.
> mem_cgroup_track_foreign_dirty_slowpath(page, wb);
> }
>
> --
> 2.17.2
>
next prev parent reply other threads:[~2019-09-23 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 8:30 Baoquan He
2019-09-23 8:42 ` Baoquan He [this message]
2019-09-24 11:11 ` [PATCH v2] " Baoquan He
2019-09-24 12:27 ` Michal Hocko
2019-09-24 13:04 ` Baoquan He
2019-09-24 13:16 ` Michal Hocko
2019-09-24 13:43 ` Baoquan He
2019-09-24 13:46 ` Michal Hocko
2019-09-24 14:19 ` [PATCH v3] " Baoquan He
2019-09-24 14:37 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923084217.GA342@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox