From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2561EC4CEC4 for ; Thu, 19 Sep 2019 19:25:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EA4542053B for ; Thu, 19 Sep 2019 19:25:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gPz9yzKZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA4542053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8BDA36B0380; Thu, 19 Sep 2019 15:25:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86E2E6B0383; Thu, 19 Sep 2019 15:25:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75D446B0385; Thu, 19 Sep 2019 15:25:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 55F7D6B0380 for ; Thu, 19 Sep 2019 15:25:04 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id E77B01E089 for ; Thu, 19 Sep 2019 19:25:03 +0000 (UTC) X-FDA: 75952648086.05.gun55_f11c6fd8ee2c X-HE-Tag: gun55_f11c6fd8ee2c X-Filterd-Recvd-Size: 1954 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Sep 2019 19:25:03 +0000 (UTC) Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 357292053B; Thu, 19 Sep 2019 19:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568921102; bh=g5OyAi72ILWvzD1XQjQDgV3T9SUTHQN1FC5bx9PVQPQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gPz9yzKZN9S7vVLFWn/fgNm+R6fyoDTwUXqe0Ew+swSg3IdQ75UOcxOkP/iwnv9Ou wYQfTvmC45Z/CCDFxCUj7FMW4Ijel8VgYcS35SP8z6IPDpvoSztKegY20bda937HlV nMBvRbvEJnn4FAyxXnyAQyMRcRtA34uSpn+YVaVM= Date: Thu, 19 Sep 2019 12:25:01 -0700 From: Andrew Morton To: "Aneesh Kumar K.V" Cc: dan.j.williams@intel.com, linux-nvdimm@lists.01.org, linux-mm@kvack.org Subject: Re: [PATCH v6] mm/pgmap: Use correct alignment when looking at first pfn from a region Message-Id: <20190919122501.df660f0d23806a3f46d11b61@linux-foundation.org> In-Reply-To: <20190917153129.12905-1-aneesh.kumar@linux.ibm.com> References: <20190917153129.12905-1-aneesh.kumar@linux.ibm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 17 Sep 2019 21:01:29 +0530 "Aneesh Kumar K.V" wrote: > vmem_altmap_offset() adjust the section aligned base_pfn offset. > So we need to make sure we account for the same when computing base_pfn. > > ie, for altmap_valid case, our pfn_first should be: > > pfn_first = altmap->base_pfn + vmem_altmap_offset(altmap); What are the user-visible runtime effects of this change?