From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80007C41514 for ; Wed, 4 Sep 2019 19:28:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D61622CED for ; Wed, 4 Sep 2019 19:28:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D61622CED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CCBF86B0007; Wed, 4 Sep 2019 15:28:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA3F36B0008; Wed, 4 Sep 2019 15:28:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBA3A6B000A; Wed, 4 Sep 2019 15:28:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 99F9B6B0007 for ; Wed, 4 Sep 2019 15:28:52 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 1F5DBA2D0 for ; Wed, 4 Sep 2019 19:28:52 +0000 (UTC) X-FDA: 75898225704.13.brick16_3044dc17e9b31 X-HE-Tag: brick16_3044dc17e9b31 X-Filterd-Recvd-Size: 6777 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Sep 2019 19:28:51 +0000 (UTC) Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BFF2711A15 for ; Wed, 4 Sep 2019 19:28:50 +0000 (UTC) Received: by mail-qk1-f199.google.com with SMTP id l64so24309956qkb.5 for ; Wed, 04 Sep 2019 12:28:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yjhFuNGCVVnCVt6KGmnRVbp0O4Ubgc+nm3QiXx2UytM=; b=Pr/U382H+EPdUXuBhx1XGc5dTMz92FFHOUo8Hh8yXCJww8d02DIXcbuMCQliKKVRJV XwBaKQ72vKHjY+OUxQr22vnp7OKvXXac1tA42u4DfwYk9XcW8UkrsEamvbVyMMPfYkmV U4deWeC2Ov4XXDcHztQEmLMZLmEb4RpR2G77o1RUvXGLsyp+d7iixYD6inLzTTxO0QDo jSnS21xNgO7Xw3aJUO2XWPmQCHa3COPUdHbM0hxvgjqYsNOHc1WPXvQ9fRdDBi0+cPgs U0AUZ2P+bCdlYZKzdDyrn6fUbMJeadjuRA2+OkH5B7vZtLwTnv7QCMQlu+vScl51ODaQ 7M3w== X-Gm-Message-State: APjAAAXy8qXa6hn0aJu4lCzP+X2We5pvYrXn+SRrXToE33QKZYVJtBdD haXYgREoUQ9eos6bBKE2l2lg9VEmfYJHEhGOQljfr1lui58n8vMEj98Ds2EKvnB83sEkb0xcdt5 JfcWuAxskKP0= X-Received: by 2002:a37:6789:: with SMTP id b131mr26895336qkc.314.1567625330116; Wed, 04 Sep 2019 12:28:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyTcr7UOJ02wFSH/Lm77j8LHfMvnSXy+Cmzc6fLXR0bnU9M8nbYOhGrXWD3d2+DWPFbWpj1zA== X-Received: by 2002:a37:6789:: with SMTP id b131mr26895315qkc.314.1567625329847; Wed, 04 Sep 2019 12:28:49 -0700 (PDT) Received: from redhat.com (bzq-79-176-40-226.red.bezeqint.net. [79.176.40.226]) by smtp.gmail.com with ESMTPSA id c137sm3451372qkg.110.2019.09.04.12.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 12:28:48 -0700 (PDT) Date: Wed, 4 Sep 2019 15:28:41 -0400 From: "Michael S. Tsirkin" To: Alexander Duyck Cc: nitesh@redhat.com, kvm@vger.kernel.org, david@redhat.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, willy@infradead.org, mhocko@kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, virtio-dev@lists.oasis-open.org, osalvador@suse.de, yang.zhang.wz@gmail.com, pagupta@redhat.com, riel@surriel.com, konrad.wilk@oracle.com, lcapitulino@redhat.com, wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com Subject: Re: [PATCH v7 5/6] virtio-balloon: Pull page poisoning config out of free page hinting Message-ID: <20190904152244-mutt-send-email-mst@kernel.org> References: <20190904150920.13848.32271.stgit@localhost.localdomain> <20190904151055.13848.27351.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190904151055.13848.27351.stgit@localhost.localdomain> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 04, 2019 at 08:10:55AM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Currently the page poisoning setting wasn't being enabled unless free page > hinting was enabled. However we will need the page poisoning tracking logic > as well for unused page reporting. As such pull it out and make it a > separate bit of config in the probe function. > > In addition we can actually wrap the code in a check for NO_SANITY. If we > don't care what is actually in the page we can just default to 0 and leave > it there. > > Signed-off-by: Alexander Duyck > --- > drivers/virtio/virtio_balloon.c | 19 +++++++++++++------ > mm/page_reporting.c | 4 ++++ > 2 files changed, 17 insertions(+), 6 deletions(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index 226fbb995fb0..2c19457ab573 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -842,7 +842,6 @@ static int virtio_balloon_register_shrinker(struct virtio_balloon *vb) > static int virtballoon_probe(struct virtio_device *vdev) > { > struct virtio_balloon *vb; > - __u32 poison_val; > int err; > > if (!vdev->config->get) { > @@ -909,11 +908,19 @@ static int virtballoon_probe(struct virtio_device *vdev) > VIRTIO_BALLOON_CMD_ID_STOP); > spin_lock_init(&vb->free_page_list_lock); > INIT_LIST_HEAD(&vb->free_page_list); > - if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) { > - memset(&poison_val, PAGE_POISON, sizeof(poison_val)); > - virtio_cwrite(vb->vdev, struct virtio_balloon_config, > - poison_val, &poison_val); > - } > + } > + if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) { > + __u32 poison_val = 0; > + > +#if !defined(CONFIG_PAGE_POISONING_NO_SANITY) > + /* > + * Let hypervisor know that we are expecting a specific > + * value to be written back in unused pages. > + */ > + memset(&poison_val, PAGE_POISON, sizeof(poison_val)); > +#endif > + virtio_cwrite(vb->vdev, struct virtio_balloon_config, > + poison_val, &poison_val); > } > /* > * We continue to use VIRTIO_BALLOON_F_DEFLATE_ON_OOM to decide if a I'm a bit confused by this part. Should we not just clear VIRTIO_BALLOON_F_PAGE_POISON completely? In my mind the value written should be what guest puts in free pages - and possibly what it expects to find there later. If it doesn't expect anything there then it makes sense to clear VIRTIO_BALLOON_F_PAGE_POISON so that host does not try to put the poison value there. But I think that it does not make sense to lie to host about the poison value - I think that if we do send poison value to host it's reasonable for host to expect free pages have that value - and even possibly to validate that. So I think that the hack belongs in virtballoon_validate, near the page_poisoning_enabled check. > diff --git a/mm/page_reporting.c b/mm/page_reporting.c > index 5006b08d5eec..35c0fe4c4471 100644 > --- a/mm/page_reporting.c > +++ b/mm/page_reporting.c > @@ -299,6 +299,10 @@ int page_reporting_startup(struct page_reporting_dev_info *phdev) > struct zone *zone; > int err = 0; > > + /* No point in enabling this if it cannot handle any pages */ > + if (!phdev->capacity) > + return -EINVAL; > + > mutex_lock(&page_reporting_mutex); > > /* nothing to do if already in use */