From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD5FC3A5A2 for ; Tue, 3 Sep 2019 07:36:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ED40722D6D for ; Tue, 3 Sep 2019 07:36:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Ljbpw4fh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED40722D6D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 97E606B0003; Tue, 3 Sep 2019 03:36:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9082E6B0005; Tue, 3 Sep 2019 03:36:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 781BA6B0006; Tue, 3 Sep 2019 03:36:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 5516C6B0003 for ; Tue, 3 Sep 2019 03:36:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id ADC71180AD801 for ; Tue, 3 Sep 2019 07:36:47 +0000 (UTC) X-FDA: 75892802454.14.trail07_1e24d06ad1814 X-HE-Tag: trail07_1e24d06ad1814 X-Filterd-Recvd-Size: 4940 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Sep 2019 07:36:46 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id q19so8067031wmc.3 for ; Tue, 03 Sep 2019 00:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+Dv55tyGyqXMrZX83SwrRIU+i9nALQjaNWq68c03GXI=; b=Ljbpw4fhx6QxNHXels3qpp2aUOAk8vlbavDiQesD0cWLwVLty3aJba0Mv+G14WwXUY J6tOlIq7x99iKlJszy6ygTHrSVdJhXdK4R9c4ECB9cFI7FJHkU28AdmbdsPcfR2wey5T 2uIj2Q78IAXWGJXaFwa7ksHJsfhMYzZrLIq9OiOBFzhKliEPePgfxIZGvexZhC2kwGKF VpZXEbGPaBuzF/kmA5CnRXOJPjaPLFjCeCMyCghU1hffYinkPrhF89gIm5WmpAAaQTiZ 5SR9ZaIV7l/UyhZjbRsOTLtl+1e1D599Ms4rDFsEtWiyRYSo254B1+YiLiOMYVPmDxGH PHtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+Dv55tyGyqXMrZX83SwrRIU+i9nALQjaNWq68c03GXI=; b=dC8LMRsLhetT/Ko1yIszj0cKfLuUTbbANi90lua/fMQSOAo/2C1xHE6Y8pDaM+aYvl f8kmMhAWfukHZdWSDPqSfdhiJuwGrqJCxgrY3xIfU7NmrwU9iap4hcMN30Gy/6435fha clE5Rbwr8ZsLscJolkdWrCMAdA6xq1Znr7E27TED5kS1nQJ5aKj+a2VbgPM8APaydbNm tE63g7c/X1djrvmidAzAX7uGxBT3TK/kb1twEfJRbBcPToZvH9QZxm69mcIJ9uEa0CmH QxDZJn4RSd60UHBHx2GaRp2LdUuzSoF4cYiHm3i5XOTPhspeBFDQDzynAA2o19nUi41G GS0Q== X-Gm-Message-State: APjAAAXjbYuoCt6jHY6E2OgZ5Vval8qp50tCD/AwxJ56YHzmnyhmm2A2 XKH5kSQ1i7PbzTOqkQfcNvApjw== X-Google-Smtp-Source: APXvYqyxuGiS8BcsynmmU6sW7DpxWQ4xWRBDdJxslrhLv19Q6kkbrC33NvvCD/8YfCrP44tF4Jl5rA== X-Received: by 2002:a7b:cc82:: with SMTP id p2mr9353932wma.165.1567496205721; Tue, 03 Sep 2019 00:36:45 -0700 (PDT) Received: from ziepe.ca ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id g26sm14684174wmh.32.2019.09.03.00.36.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Sep 2019 00:36:45 -0700 (PDT) Received: from jgg by jggl.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1i53Mq-00012C-1s; Tue, 03 Sep 2019 04:36:44 -0300 Date: Tue, 3 Sep 2019 04:36:44 -0300 From: Jason Gunthorpe To: Daniel Vetter Cc: LKML , Linux MM , DRI Development , Peter Zijlstra , Ingo Molnar , Andrew Morton , Michal Hocko , David Rientjes , Christian =?utf-8?B?S8O2bmln?= , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Masahiro Yamada , Wei Wang , Andy Shevchenko , Thomas Gleixner , Jann Horn , Feng Tang , Kees Cook , Randy Dunlap , Daniel Vetter Subject: Re: [PATCH 3/5] kernel.h: Add non_block_start/end() Message-ID: <20190903073644.GB4500@ziepe.ca> References: <20190826201425.17547-1-daniel.vetter@ffwll.ch> <20190826201425.17547-4-daniel.vetter@ffwll.ch> <20190827225002.GB30700@ziepe.ca> <20190828184330.GD933@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 03, 2019 at 09:28:23AM +0200, Daniel Vetter wrote: > > Cleanest would be a new header I guess, together with might_sleep(). > > But moving that is a bit much I think, there's almost 500 callers of > > that one from a quick git grep > > > > > If dropping do while is the only change then I can edit it in.. > > > I think we have the acks now > > > > Yeah sounds simplest, thanks. > > Hi Jason, > > Do you expect me to resend now, or do you plan to do the patchwork > appeasement when applying? I've seen you merged the other patches > (thanks!), but not these two here. Sorry, I didn't get to this before I started travelling, and deferred it since we were having linux-next related problems with hmm.git. I hope to do it today. I will fix it up as promised Thanks, Jason