linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: linux-mm@kvack.org
Cc: henryburns@google.com
Subject: zsmalloc build fails without CONFIG_COMPACTION
Date: Fri, 30 Aug 2019 14:39:45 +0200	[thread overview]
Message-ID: <20190830143945.223ebf94@suse.de> (raw)

Hi,

I'm hitting this build failure with today's master
(26538100499460ee81546a0dc8d6f14f5151d427):

  CC      mm/zsmalloc.o
In file included from ./include/linux/mmzone.h:10:0,
                 from ./include/linux/gfp.h:6,
                 from ./include/linux/umh.h:4,
                 from ./include/linux/kmod.h:9,
                 from ./include/linux/module.h:13,
                 from mm/zsmalloc.c:33:
mm/zsmalloc.c: In function ‘zs_create_pool’:
mm/zsmalloc.c:2415:27: error: ‘struct zs_pool’ has no member named ‘migration_wait’
  init_waitqueue_head(&pool->migration_wait);
                           ^
./include/linux/wait.h:67:26: note: in definition of macro ‘init_waitqueue_head’
   __init_waitqueue_head((wq_head), #wq_head, &__key);  \
                          ^~~~~~~
make[1]: *** [scripts/Makefile.build:281: mm/zsmalloc.o] Error 1
make: *** [Makefile:1083: mm] Error 2

It looks like this is due to:
701d678599d0 ("mm/zsmalloc.c: fix race condition in zs_destroy_pool")

Cheers, David


                 reply	other threads:[~2019-08-30 12:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190830143945.223ebf94@suse.de \
    --to=ddiss@suse.de \
    --cc=henryburns@google.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox