From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E71ADC3A5A1 for ; Wed, 28 Aug 2019 18:43:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A2C7B208C2 for ; Wed, 28 Aug 2019 18:43:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="HbHXDrzL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2C7B208C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3DDC06B0005; Wed, 28 Aug 2019 14:43:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B3686B000C; Wed, 28 Aug 2019 14:43:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A26A6B000D; Wed, 28 Aug 2019 14:43:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 0790B6B0005 for ; Wed, 28 Aug 2019 14:43:33 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 9AC97180AD801 for ; Wed, 28 Aug 2019 18:43:33 +0000 (UTC) X-FDA: 75872709906.17.feet02_7653ed5a80648 X-HE-Tag: feet02_7653ed5a80648 X-Filterd-Recvd-Size: 7278 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Aug 2019 18:43:33 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id t12so686090qtp.9 for ; Wed, 28 Aug 2019 11:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OjPkEOv+DLtOkFTqeu8lwQuWyFpGs0nrOsZbcx7SOSc=; b=HbHXDrzLqc3lpVU55Nd/0BI2SIQ2x72GzuKH/C2UAiJOAp38bcuMdbQptguyCeoa8S XtS6TSStn/7XppLzX0ltVtzjXABmeo1iBZlbJIsc4IjxoQVNK0XgHoe5qnT8leWBFLKp ygUAeNgUsdCWiSK9m1VX/B1VNJIeObqWI6AHSZGYIK+Qowf5xQW46ccAvDBEfsckznWb MmKN+mdFBQ6Nzf54I3ucE1GI2CyvGbcHp7ySqkRKMENGHCY7dCaaAu8QWTMfUcwQtNxa Ro8JrnGi/uzzbWR34UB7mEtJw9KlHNFZfY2+dANrWQiodo233hpz5sMhLvpLGJJjf8W7 2liA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OjPkEOv+DLtOkFTqeu8lwQuWyFpGs0nrOsZbcx7SOSc=; b=tQIAZGpucSq5Oulub+0gS1KJQWL9mZxFF3EF1e1qNqaCODlevz52Zef3hCW6NAXTil 3CWtRNP26yAEWwRNGJLqt/A9ieRdtPB1MvLZSaUrE/Gk5rIuhr3jSRVwOQTmhuu0Vfq6 VY4wntjRNRgivbmgX/E9PEi7HGTRg0NDle9GVspCFt5YakHuCKLhu/TvfKeMNQruy4gv 9eViHuOkc2LfhKjv07YErTdhq4h75BGh8Qk+PQnC8QGvZPBBy48yNoJHzFdg6hP1CDN1 U7Lzn3D+MIkc94c4gYzD95t0VDgj+v5gZJbt6HK9SvZa5Z/ns9Jzphjes43gG7jcqYi/ DALA== X-Gm-Message-State: APjAAAUEoPoxmUkxtjc/RTRbQgyvCfMuSIkvw90tenmUPpNsPVzTK7MA aFq8lh2K+eDNH/1dM7og5gOTbw== X-Google-Smtp-Source: APXvYqyEQcVWQf49+hXcQCirgyPBJnM1VH//y0tMVxtn+SNqmDh6w+F0CMCxwxOy8DpklWetu0fhmA== X-Received: by 2002:ac8:750e:: with SMTP id u14mr5800709qtq.282.1567017812387; Wed, 28 Aug 2019 11:43:32 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-216-168.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.216.168]) by smtp.gmail.com with ESMTPSA id k11sm21089qtp.26.2019.08.28.11.43.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 11:43:31 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1i32uo-0006U8-Rg; Wed, 28 Aug 2019 15:43:30 -0300 Date: Wed, 28 Aug 2019 15:43:30 -0300 From: Jason Gunthorpe To: Daniel Vetter Cc: LKML , Linux MM , DRI Development , Peter Zijlstra , Ingo Molnar , Andrew Morton , Michal Hocko , David Rientjes , Christian =?utf-8?B?S8O2bmln?= , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Masahiro Yamada , Wei Wang , Andy Shevchenko , Thomas Gleixner , Jann Horn , Feng Tang , Kees Cook , Randy Dunlap , Daniel Vetter Subject: Re: [PATCH 3/5] kernel.h: Add non_block_start/end() Message-ID: <20190828184330.GD933@ziepe.ca> References: <20190826201425.17547-1-daniel.vetter@ffwll.ch> <20190826201425.17547-4-daniel.vetter@ffwll.ch> <20190827225002.GB30700@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 28, 2019 at 08:33:13PM +0200, Daniel Vetter wrote: > On Wed, Aug 28, 2019 at 12:50 AM Jason Gunthorpe wrote: > > > > > diff --git a/include/linux/kernel.h b/include/linux/kernel.h > > > index 4fa360a13c1e..82f84cfe372f 100644 > > > +++ b/include/linux/kernel.h > > > @@ -217,7 +217,9 @@ extern void __cant_sleep(const char *file, int line, int preempt_offset); > > > * might_sleep - annotation for functions that can sleep > > > * > > > * this macro will print a stack trace if it is executed in an atomic > > > - * context (spinlock, irq-handler, ...). > > > + * context (spinlock, irq-handler, ...). Additional sections where blocking is > > > + * not allowed can be annotated with non_block_start() and non_block_end() > > > + * pairs. > > > * > > > * This is a useful debugging help to be able to catch problems early and not > > > * be bitten later when the calling function happens to sleep when it is not > > > @@ -233,6 +235,25 @@ extern void __cant_sleep(const char *file, int line, int preempt_offset); > > > # define cant_sleep() \ > > > do { __cant_sleep(__FILE__, __LINE__, 0); } while (0) > > > # define sched_annotate_sleep() (current->task_state_change = 0) > > > +/** > > > + * non_block_start - annotate the start of section where sleeping is prohibited > > > + * > > > + * This is on behalf of the oom reaper, specifically when it is calling the mmu > > > + * notifiers. The problem is that if the notifier were to block on, for example, > > > + * mutex_lock() and if the process which holds that mutex were to perform a > > > + * sleeping memory allocation, the oom reaper is now blocked on completion of > > > + * that memory allocation. Other blocking calls like wait_event() pose similar > > > + * issues. > > > + */ > > > +# define non_block_start() \ > > > + do { current->non_block_count++; } while (0) > > > +/** > > > + * non_block_end - annotate the end of section where sleeping is prohibited > > > + * > > > + * Closes a section opened by non_block_start(). > > > + */ > > > +# define non_block_end() \ > > > + do { WARN_ON(current->non_block_count-- == 0); } while (0) > > > > check-patch does not like these, and I agree > > > > #101: FILE: include/linux/kernel.h:248: > > +# define non_block_start() \ > > + do { current->non_block_count++; } while (0) > > > > /tmp/tmp1spfxufy/0006-kernel-h-Add-non_block_start-end-.patch:108: WARNING: Single statement macros should not use a do {} while (0) loop > > #108: FILE: include/linux/kernel.h:255: > > +# define non_block_end() \ > > + do { WARN_ON(current->non_block_count-- == 0); } while (0) > > > > Please use a static inline? > > We need get_current() plus the task_struct, so this gets real messy > real fast. Not even sure which header this would fit in, or whether > I'd need to create a new one. You're insisting on this or respinning > with the do { } while (0) dropped ok. My prefernce is always a static inline, but if the headers are so twisty we need to use #define to solve a missing include, then I wouldn't insist on it. If dropping do while is the only change then I can edit it in.. I think we have the acks now Jason