* [PATCH] mm/oom_kill.c: fox oom_cpuset_eligible() comment
@ 2019-08-28 2:38 Yi Wang
2019-08-28 7:10 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Yi Wang @ 2019-08-28 2:38 UTC (permalink / raw)
To: akpm
Cc: mhocko, penguin-kernel, guro, shakeelb, yuzhoujian, jglisse,
ebiederm, hannes, linux-mm, linux-kernel, xue.zhihong, wang.yi59,
up2wing, wang.liang82
Commit ac311a14c682 ("oom: decouple mems_allowed from oom_unkillable_task")
changed the function has_intersects_mems_allowed() to
oom_cpuset_eligible(), but didn't change the comment meanwhile.
Let's fix this.
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
mm/oom_kill.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index eda2e2a..65c092e 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -73,7 +73,7 @@ static inline bool is_memcg_oom(struct oom_control *oc)
/**
* oom_cpuset_eligible() - check task eligiblity for kill
* @start: task struct of which task to consider
- * @mask: nodemask passed to page allocator for mempolicy ooms
+ * @oc: pointer to struct oom_control
*
* Task eligibility is determined by whether or not a candidate task, @tsk,
* shares the same mempolicy nodes as current if it is bound by such a policy
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/oom_kill.c: fox oom_cpuset_eligible() comment
2019-08-28 2:38 [PATCH] mm/oom_kill.c: fox oom_cpuset_eligible() comment Yi Wang
@ 2019-08-28 7:10 ` Michal Hocko
2019-08-28 7:40 ` wang.yi59
0 siblings, 1 reply; 3+ messages in thread
From: Michal Hocko @ 2019-08-28 7:10 UTC (permalink / raw)
To: Yi Wang
Cc: akpm, penguin-kernel, guro, shakeelb, yuzhoujian, jglisse,
ebiederm, hannes, linux-mm, linux-kernel, xue.zhihong, up2wing,
wang.liang82
s@fox@fix@
On Wed 28-08-19 10:38:49, Yi Wang wrote:
> Commit ac311a14c682 ("oom: decouple mems_allowed from oom_unkillable_task")
> changed the function has_intersects_mems_allowed() to
> oom_cpuset_eligible(), but didn't change the comment meanwhile.
>
> Let's fix this.
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> ---
> mm/oom_kill.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index eda2e2a..65c092e 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -73,7 +73,7 @@ static inline bool is_memcg_oom(struct oom_control *oc)
> /**
> * oom_cpuset_eligible() - check task eligiblity for kill
> * @start: task struct of which task to consider
> - * @mask: nodemask passed to page allocator for mempolicy ooms
> + * @oc: pointer to struct oom_control
> *
> * Task eligibility is determined by whether or not a candidate task, @tsk,
> * shares the same mempolicy nodes as current if it is bound by such a policy
> --
> 1.8.3.1
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re:[PATCH] mm/oom_kill.c: fox oom_cpuset_eligible() comment
2019-08-28 7:10 ` Michal Hocko
@ 2019-08-28 7:40 ` wang.yi59
0 siblings, 0 replies; 3+ messages in thread
From: wang.yi59 @ 2019-08-28 7:40 UTC (permalink / raw)
To: mhocko
Cc: akpm, penguin-kernel, guro, shakeelb, yuzhoujian, jglisse,
ebiederm, hannes, linux-mm, linux-kernel, xue.zhihong, up2wing,
wang.liang82
[-- Attachment #1.1: Type: text/plain, Size: 1224 bytes --]
Hi Michal,
Thanks for your ack and sorry for my spelling mistake :(
> s@fox@fix@
>
> On Wed 28-08-19 10:38:49, Yi Wang wrote:
> > Commit ac311a14c682 ("oom: decouple mems_allowed from oom_unkillable_task")
> > changed the function has_intersects_mems_allowed() to
> > oom_cpuset_eligible(), but didn't change the comment meanwhile.
> >
> > Let's fix this.
> >
> > Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> Thanks!
>
> > ---
> > mm/oom_kill.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> > index eda2e2a..65c092e 100644
> > --- a/mm/oom_kill.c
> > +++ b/mm/oom_kill.c
> > @@ -73,7 +73,7 @@ static inline bool is_memcg_oom(struct oom_control *oc)
> > /**
> > * oom_cpuset_eligible() - check task eligiblity for kill
> > * @start: task struct of which task to consider
> > - * @mask: nodemask passed to page allocator for mempolicy ooms
> > + * @oc: pointer to struct oom_control
> > *
> > * Task eligibility is determined by whether or not a candidate task, @tsk,
> > * shares the same mempolicy nodes as current if it is bound by such a policy
> > --
> > 1.8.3.1
> >
---
Best wishes
Yi Wang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-28 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-28 2:38 [PATCH] mm/oom_kill.c: fox oom_cpuset_eligible() comment Yi Wang
2019-08-28 7:10 ` Michal Hocko
2019-08-28 7:40 ` wang.yi59
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox