Re:[PATCH] mm/oom_kill.c: fox oom_cpuset_eligible() comment

[<wang.yi59@zte.com.cn>]

[-- Attachment #1.1: Type: text/plain, Size: 1224 bytes --]

Hi Michal,

Thanks for your ack and sorry for my spelling mistake :(

> s@fox@fix@
>
> On Wed 28-08-19 10:38:49, Yi Wang wrote:
> > Commit ac311a14c682 ("oom: decouple mems_allowed from oom_unkillable_task")
> > changed the function has_intersects_mems_allowed() to
> > oom_cpuset_eligible(), but didn't change the comment meanwhile.
> >
> > Let's fix this.
> >
> > Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> Thanks!
>
> > ---
> >  mm/oom_kill.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> > index eda2e2a..65c092e 100644
> > --- a/mm/oom_kill.c
> > +++ b/mm/oom_kill.c
> > @@ -73,7 +73,7 @@ static inline bool is_memcg_oom(struct oom_control *oc)
> >  /**
> >   * oom_cpuset_eligible() - check task eligiblity for kill
> >   * @start: task struct of which task to consider
> > - * @mask: nodemask passed to page allocator for mempolicy ooms
> > + * @oc: pointer to struct oom_control
> >   *
> >   * Task eligibility is determined by whether or not a candidate task, @tsk,
> >   * shares the same mempolicy nodes as current if it is bound by such a policy
> > --
> > 1.8.3.1
> >


---
Best wishes
Yi Wang