[PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports

[PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports

[Christoph Hellwig]

Bo modular code uses these, which makes a lot of sense given the
wrappers around them are only called by core mm code.

Also remove the recently added __mmu_notifier_invalidate_range_start_map
export for which the same applies.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 mm/mmu_notifier.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
index 690f1ea639d5..240f4e14d42e 100644
--- a/mm/mmu_notifier.c
+++ b/mm/mmu_notifier.c
@@ -25,7 +25,6 @@ DEFINE_STATIC_SRCU(srcu);
 struct lockdep_map __mmu_notifier_invalidate_range_start_map = {
 	.name = "mmu_notifier_invalidate_range_start"
 };
-EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start_map);
 #endif
 
 /*
@@ -184,7 +183,6 @@ int __mmu_notifier_invalidate_range_start(struct mmu_notifier_range *range)
 
 	return ret;
 }
-EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start);
 
 void __mmu_notifier_invalidate_range_end(struct mmu_notifier_range *range,
 					 bool only_end)
@@ -218,7 +216,6 @@ void __mmu_notifier_invalidate_range_end(struct mmu_notifier_range *range,
 	srcu_read_unlock(&srcu, id);
 	lock_map_release(&__mmu_notifier_invalidate_range_start_map);
 }
-EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_end);
 
 void __mmu_notifier_invalidate_range(struct mm_struct *mm,
 				  unsigned long start, unsigned long end)
-- 
2.20.1

Re: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports

[Jason Gunthorpe]

On Wed, Aug 28, 2019 at 04:21:09PM +0200, Christoph Hellwig wrote:
> Bo modular code uses these, which makes a lot of sense given the
> wrappers around them are only called by core mm code.

/Bo/No/

> Also remove the recently added __mmu_notifier_invalidate_range_start_map
> export for which the same applies.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>  mm/mmu_notifier.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
> index 690f1ea639d5..240f4e14d42e 100644
> +++ b/mm/mmu_notifier.c
> @@ -25,7 +25,6 @@ DEFINE_STATIC_SRCU(srcu);
>  struct lockdep_map __mmu_notifier_invalidate_range_start_map = {
>  	.name = "mmu_notifier_invalidate_range_start"
>  };
> -EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start_map);
>  #endif

I inlined this hunk into Daniel's patch from yesterday

Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>

Applied to hmm.git..

What about:

EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range);

elixir suggest this is not called outside mm/ either?

Jason

Re: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports

[Christoph Hellwig]

On Wed, Aug 28, 2019 at 02:40:25PM +0000, Jason Gunthorpe wrote:
> EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range);
> 
> elixir suggest this is not called outside mm/ either?

Yes, it seems like that one should go away as well.

Re: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports

[Jason Gunthorpe]

On Wed, Aug 28, 2019 at 04:47:28PM +0200, Christoph Hellwig wrote:
> On Wed, Aug 28, 2019 at 02:40:25PM +0000, Jason Gunthorpe wrote:
> > EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range);
> > 
> > elixir suggest this is not called outside mm/ either?
> 
> Yes, it seems like that one should go away as well.

I will amend this patch to drop it too and send it through 0-day

Thanks,
Jason