linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@mellanox.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>
Subject: Re: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports
Date: Wed, 28 Aug 2019 14:40:25 +0000	[thread overview]
Message-ID: <20190828144020.GI914@mellanox.com> (raw)
In-Reply-To: <20190828142109.29012-1-hch@lst.de>

On Wed, Aug 28, 2019 at 04:21:09PM +0200, Christoph Hellwig wrote:
> Bo modular code uses these, which makes a lot of sense given the
> wrappers around them are only called by core mm code.

/Bo/No/

> Also remove the recently added __mmu_notifier_invalidate_range_start_map
> export for which the same applies.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>  mm/mmu_notifier.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
> index 690f1ea639d5..240f4e14d42e 100644
> +++ b/mm/mmu_notifier.c
> @@ -25,7 +25,6 @@ DEFINE_STATIC_SRCU(srcu);
>  struct lockdep_map __mmu_notifier_invalidate_range_start_map = {
>  	.name = "mmu_notifier_invalidate_range_start"
>  };
> -EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start_map);
>  #endif

I inlined this hunk into Daniel's patch from yesterday

Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>

Applied to hmm.git..

What about:

EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range);

elixir suggest this is not called outside mm/ either?

Jason


  reply	other threads:[~2019-08-28 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28 14:21 Christoph Hellwig
2019-08-28 14:40 ` Jason Gunthorpe [this message]
2019-08-28 14:47   ` Christoph Hellwig
2019-08-28 14:49     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828144020.GI914@mellanox.com \
    --to=jgg@mellanox.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel@ffwll.ch \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox