From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E69AC3A5A1 for ; Wed, 28 Aug 2019 14:03:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 221B62080F for ; Wed, 28 Aug 2019 14:03:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="BjTJ1X09" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 221B62080F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9DE076B0008; Wed, 28 Aug 2019 10:03:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98E7D6B000C; Wed, 28 Aug 2019 10:03:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87C926B000D; Wed, 28 Aug 2019 10:03:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 613D26B0008 for ; Wed, 28 Aug 2019 10:03:30 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 0C4C2BF18 for ; Wed, 28 Aug 2019 14:03:30 +0000 (UTC) X-FDA: 75872004180.15.brush94_152e3cc98816 X-HE-Tag: brush94_152e3cc98816 X-Filterd-Recvd-Size: 8888 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Aug 2019 14:03:28 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id h8so154058edv.7 for ; Wed, 28 Aug 2019 07:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pUd3m4DsM7BTeNbPVwQgbVgdSNN5DvcolcmC2Ql3+nU=; b=BjTJ1X09BzCUN38w6rpH9CpwQMRT+Bh48KuewQie9HhUYXT6DSkm+W03BRraBSh7zW X9P6xjW3VPZ/HWlF/3qwoZSExSf7KIwYSnoIek+9XVVLncPj+SFnMzg1AkFjJn0dhjMZ 1w7m4B2khXFKewQQ//IrHe/Le8avKB8tqxDUXSmuQQTYe2dArXOKfv6wVxHtDnCcHfHs gyH0CDUfNMGIl08bAGg2GXXS0B/ypqKq/ltifqzEg9pBO+Jd/YBBEJ8Gt/RgpsOyDa60 zCOsyJvPBmicpA10K5gSiobiNivqqtESKm/OSfL0Brt5qCzczegNQMhKp8X+a1E+dlCr Ml0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pUd3m4DsM7BTeNbPVwQgbVgdSNN5DvcolcmC2Ql3+nU=; b=hqjwjSH8IyELFuz0wfIjw6mp2mb1K4JU18PJrhS5sX2CaOn7aR+2WNpPq4XEl0IY0x 2JayL7hxXJCy1um5CT/dQBnfu4vuWxxncF6RfZYLphHhZMPk0eHMq0MKb8/rgy+6OYSn xWljB1EP/qiYqe5kKHkqVGm2GG5dI49jZC3mHaaw6eVlVKzvFRPWLW45Me+zpBWtG4iq oLNH4WhWHivB5QXuM2QDo6Hk38n+/Rw2pEQV9ziy3w2XBYCyg6g3qstCw4FxeOAZni5b Xmi2VpHii4qo8KMekT3YRIYX/z+knrvdnuZlIH34L7D/xy8i9jioBsnB0KhpTiYXEvl1 7jHQ== X-Gm-Message-State: APjAAAXAH+IFG9onEBG6gh1ShLJe2jq2xr8ZqEtn9oIyX6lgymnqAjjy Pf9cLvHqFtgIMJah5JDXw9cfoQ== X-Google-Smtp-Source: APXvYqx4F0/oYwYwiSZeMVH8GZbGtmYDTML+qzGZXbX4+VAd0dmbAwrZ4tBT6Q9UELleMKFYpiMQ6Q== X-Received: by 2002:a17:906:80da:: with SMTP id a26mr3394346ejx.222.1567001007528; Wed, 28 Aug 2019 07:03:27 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id y37sm483972edb.42.2019.08.28.07.03.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Aug 2019 07:03:26 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id CD1651009F2; Wed, 28 Aug 2019 17:03:29 +0300 (+03) Date: Wed, 28 Aug 2019 17:03:29 +0300 From: "Kirill A. Shutemov" To: Michal Hocko Cc: Yang Shi , Vlastimil Babka , kirill.shutemov@linux.intel.com, hannes@cmpxchg.org, rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH -mm] mm: account deferred split THPs into MemAvailable Message-ID: <20190828140329.qpcrfzg2hmkccnoq@box> References: <20190826074035.GD7538@dhcp22.suse.cz> <20190826131538.64twqx3yexmhp6nf@box> <20190827060139.GM7538@dhcp22.suse.cz> <20190827110210.lpe36umisqvvesoa@box> <20190827120923.GB7538@dhcp22.suse.cz> <20190827121739.bzbxjloq7bhmroeq@box> <20190827125911.boya23eowxhqmopa@box> <20190828075708.GF7386@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190828075708.GF7386@dhcp22.suse.cz> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 28, 2019 at 09:57:08AM +0200, Michal Hocko wrote: > On Tue 27-08-19 10:06:20, Yang Shi wrote: > > > > > > On 8/27/19 5:59 AM, Kirill A. Shutemov wrote: > > > On Tue, Aug 27, 2019 at 03:17:39PM +0300, Kirill A. Shutemov wrote: > > > > On Tue, Aug 27, 2019 at 02:09:23PM +0200, Michal Hocko wrote: > > > > > On Tue 27-08-19 14:01:56, Vlastimil Babka wrote: > > > > > > On 8/27/19 1:02 PM, Kirill A. Shutemov wrote: > > > > > > > On Tue, Aug 27, 2019 at 08:01:39AM +0200, Michal Hocko wrote: > > > > > > > > On Mon 26-08-19 16:15:38, Kirill A. Shutemov wrote: > > > > > > > > > Unmapped completely pages will be freed with current code. Deferred split > > > > > > > > > only applies to partly mapped THPs: at least on 4k of the THP is still > > > > > > > > > mapped somewhere. > > > > > > > > Hmm, I am probably misreading the code but at least current Linus' tree > > > > > > > > reads page_remove_rmap -> [page_remove_anon_compound_rmap ->\ deferred_split_huge_page even > > > > > > > > for fully mapped THP. > > > > > > > Well, you read correctly, but it was not intended. I screwed it up at some > > > > > > > point. > > > > > > > > > > > > > > See the patch below. It should make it work as intened. > > > > > > > > > > > > > > It's not bug as such, but inefficientcy. We add page to the queue where > > > > > > > it's not needed. > > > > > > But that adding to queue doesn't affect whether the page will be freed > > > > > > immediately if there are no more partial mappings, right? I don't see > > > > > > deferred_split_huge_page() pinning the page. > > > > > > So your patch wouldn't make THPs freed immediately in cases where they > > > > > > haven't been freed before immediately, it just fixes a minor > > > > > > inefficiency with queue manipulation? > > > > > Ohh, right. I can see that in free_transhuge_page now. So fully mapped > > > > > THPs really do not matter and what I have considered an odd case is > > > > > really happening more often. > > > > > > > > > > That being said this will not help at all for what Yang Shi is seeing > > > > > and we need a more proactive deferred splitting as I've mentioned > > > > > earlier. > > > > It was not intended to fix the issue. It's fix for current logic. I'm > > > > playing with the work approach now. > > > Below is what I've come up with. It appears to be functional. > > > > > > Any comments? > > > > Thanks, Kirill and Michal. Doing split more proactive is definitely a choice > > to eliminate huge accumulated deferred split THPs, I did think about this > > approach before I came up with memcg aware approach. But, I thought this > > approach has some problems: > > > > First of all, we can't prove if this is a universal win for the most > > workloads or not. For some workloads (as I mentioned about our usecase), we > > do see a lot THPs accumulated for a while, but they are very short-lived for > > other workloads, i.e. kernel build. > > > > Secondly, it may be not fair for some workloads which don't generate too > > many deferred split THPs or those THPs are short-lived. Actually, the cpu > > time is abused by the excessive deferred split THPs generators, isn't it? > > Yes this is indeed true. Do we have any idea on how much time that > actually is? For uncontented case, splitting 1G worth of pages (2MiB x 512) takes a bit more than 50 ms in my setup. But it's best-case scenario: pages not shared across multiple processes, no contention on ptl, page lock, etc. > > With memcg awareness, the deferred split THPs actually are isolated and > > capped by memcg. The long-lived deferred split THPs can't be accumulated too > > many due to the limit of memcg. And, cpu time spent in splitting them would > > just account to the memcgs who generate that many deferred split THPs, who > > generate them who pay for it. This sounds more fair and we could achieve > > much better isolation. > > On the other hand, deferring the split and free up a non trivial amount > of memory is a problem I consider quite serious because it affects not > only the memcg workload which has to do the reclaim but also other > consumers of memory beucase large memory blocks could be used for higher > order allocations. Maybe instead of drive the split from number of pages on queue we can take a hint from compaction that is struggles to get high order pages? We can also try to use schedule_delayed_work() instead of plain schedule_work() to give short-lived page chance to get freed before splitting attempt. > > And, I think the discussion is diverted and mislead by the number of > > excessive deferred split THPs. To be clear, I didn't mean the excessive > > deferred split THPs are problem for us (I agree it may waste memory to have > > that many deferred split THPs not usable), the problem is the oom since they > > couldn't be split by memcg limit reclaim since the shrinker was not memcg > > aware. > > Well, I would like to see how much of a problem the memcg OOM really is > after deferred splitting is more time constrained. Maybe we will find > that there is no special memcg aware solution really needed. > -- > Michal Hocko > SUSE Labs -- Kirill A. Shutemov