From: Michal Hocko <mhocko@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: mike.kravetz@oracle.com, shuah@kernel.org, rientjes@google.com,
shakeelb@google.com, gthelen@google.com,
akpm@linux-foundation.org, khalid.aziz@oracle.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org,
aneesh.kumar@linux.vnet.ibm.com, mkoutny@suse.com
Subject: Re: [PATCH v3 0/6] hugetlb_cgroup: Add hugetlb_cgroup reservation limits
Date: Wed, 28 Aug 2019 13:23:40 +0200 [thread overview]
Message-ID: <20190828112340.GB7466@dhcp22.suse.cz> (raw)
In-Reply-To: <20190826233240.11524-1-almasrymina@google.com>
On Mon 26-08-19 16:32:34, Mina Almasry wrote:
> mm/hugetlb.c | 493 ++++++++++++------
> mm/hugetlb_cgroup.c | 187 +++++--
This is a lot of changes to an already subtle code which hugetlb
reservations undoubly are. Moreover cgroupv1 is feature frozen and I am
not aware of any plans to port the controller to v2. That all doesn't
sound in favor of this change. Mike is the maintainer of the hugetlb
code so I will defer to him to make a decision but I wouldn't recommend
that.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-08-28 11:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 23:32 Mina Almasry
2019-08-26 23:32 ` [PATCH v3 1/6] hugetlb_cgroup: Add hugetlb_cgroup reservation counter Mina Almasry
2019-08-26 23:32 ` [PATCH v3 2/6] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations Mina Almasry
2019-08-26 23:32 ` [PATCH v3 3/6] hugetlb_cgroup: add reservation accounting for private mappings Mina Almasry
2019-08-26 23:32 ` [PATCH v3 4/6] hugetlb_cgroup: add accounting for shared mappings Mina Almasry
2019-08-26 23:32 ` [PATCH v3 5/6] hugetlb_cgroup: Add hugetlb_cgroup reservation tests Mina Almasry
2019-08-26 23:32 ` [PATCH v3 6/6] hugetlb_cgroup: Add hugetlb_cgroup reservation docs Mina Almasry
2019-08-27 8:00 ` [PATCH v3 1/6] hugetlb_cgroup: Add hugetlb_cgroup reservation counter Hillf Danton
2019-08-27 9:18 ` [PATCH v3 6/6] hugetlb_cgroup: Add hugetlb_cgroup reservation docs Hillf Danton
2019-08-28 11:23 ` Michal Hocko [this message]
2019-08-28 17:58 ` [PATCH v3 0/6] hugetlb_cgroup: Add hugetlb_cgroup reservation limits Mina Almasry
2019-08-29 7:18 ` Michal Hocko
2019-09-03 17:57 ` Mike Kravetz
2019-09-03 23:44 ` Mike Kravetz
2019-09-05 20:07 ` Mina Almasry
2019-09-05 19:55 ` Mina Almasry
2019-08-29 0:42 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828112340.GB7466@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=khalid.aziz@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=mkoutny@suse.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox