From: Michal Hocko <mhocko@kernel.org>
To: Yi Wang <wang.yi59@zte.com.cn>
Cc: akpm@linux-foundation.org, penguin-kernel@I-love.SAKURA.ne.jp,
guro@fb.com, shakeelb@google.com, yuzhoujian@didichuxing.com,
jglisse@redhat.com, ebiederm@xmission.com, hannes@cmpxchg.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
xue.zhihong@zte.com.cn, up2wing@gmail.com,
wang.liang82@zte.com.cn
Subject: Re: [PATCH] mm/oom_kill.c: fox oom_cpuset_eligible() comment
Date: Wed, 28 Aug 2019 09:10:21 +0200 [thread overview]
Message-ID: <20190828071021.GD7386@dhcp22.suse.cz> (raw)
In-Reply-To: <1566959929-10638-1-git-send-email-wang.yi59@zte.com.cn>
s@fox@fix@
On Wed 28-08-19 10:38:49, Yi Wang wrote:
> Commit ac311a14c682 ("oom: decouple mems_allowed from oom_unkillable_task")
> changed the function has_intersects_mems_allowed() to
> oom_cpuset_eligible(), but didn't change the comment meanwhile.
>
> Let's fix this.
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> ---
> mm/oom_kill.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index eda2e2a..65c092e 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -73,7 +73,7 @@ static inline bool is_memcg_oom(struct oom_control *oc)
> /**
> * oom_cpuset_eligible() - check task eligiblity for kill
> * @start: task struct of which task to consider
> - * @mask: nodemask passed to page allocator for mempolicy ooms
> + * @oc: pointer to struct oom_control
> *
> * Task eligibility is determined by whether or not a candidate task, @tsk,
> * shares the same mempolicy nodes as current if it is bound by such a policy
> --
> 1.8.3.1
>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-08-28 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 2:38 Yi Wang
2019-08-28 7:10 ` Michal Hocko [this message]
2019-08-28 7:40 ` wang.yi59
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828071021.GD7386@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=shakeelb@google.com \
--cc=up2wing@gmail.com \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox