linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: Alastair D'Silva <alastair@au1.ibm.com>
Cc: alastair@d-silva.org, Andrew Morton <akpm@linux-foundation.org>,
	Oscar Salvador <osalvador@suse.de>,
	Michal Hocko <mhocko@suse.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Mike Rapoport <rppt@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Wei Yang <richardw.yang@linux.intel.com>, Qian Cai <cai@lca.pw>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: Don't manually decrement num_poisoned_pages
Date: Wed, 28 Aug 2019 08:39:03 +0800	[thread overview]
Message-ID: <20190828003903.GB15462@richard> (raw)
In-Reply-To: <20190827053656.32191-2-alastair@au1.ibm.com>

On Tue, Aug 27, 2019 at 03:36:54PM +1000, Alastair D'Silva wrote:
>From: Alastair D'Silva <alastair@d-silva.org>
>
>Use the function written to do it instead.
>
>Signed-off-by: Alastair D'Silva <alastair@d-silva.org>

Reviewed-by: Wei Yang <richardw.yang@linux.intel.com>

>---
> mm/sparse.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/mm/sparse.c b/mm/sparse.c
>index 72f010d9bff5..e41917a7e844 100644
>--- a/mm/sparse.c
>+++ b/mm/sparse.c
>@@ -11,6 +11,8 @@
> #include <linux/export.h>
> #include <linux/spinlock.h>
> #include <linux/vmalloc.h>
>+#include <linux/swap.h>
>+#include <linux/swapops.h>
> 
> #include "internal.h"
> #include <asm/dma.h>
>@@ -898,7 +900,7 @@ static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages)
> 
> 	for (i = 0; i < nr_pages; i++) {
> 		if (PageHWPoison(&memmap[i])) {
>-			atomic_long_sub(1, &num_poisoned_pages);
>+			num_poisoned_pages_dec();
> 			ClearPageHWPoison(&memmap[i]);
> 		}
> 	}
>-- 
>2.21.0

-- 
Wei Yang
Help you, Help me


  parent reply	other threads:[~2019-08-28  0:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27  5:36 [PATCH 0/2] mm: Minor cleanup Alastair D'Silva
2019-08-27  5:36 ` [PATCH 1/2] mm: Don't manually decrement num_poisoned_pages Alastair D'Silva
2019-08-27  6:25   ` Michal Hocko
2019-08-27  7:07   ` David Hildenbrand
2019-08-27  7:31   ` Mike Rapoport
2019-08-28  0:39   ` Wei Yang [this message]
2019-08-28  7:31   ` Oscar Salvador
2019-08-27  5:36 ` [PATCH 2/2] mm: don't hide potentially null memmap pointer in sparse_remove_section Alastair D'Silva
2019-08-27  6:24   ` Michal Hocko
2019-08-27  7:00     ` Alastair D'Silva
2019-08-27  7:08       ` David Hildenbrand
2019-08-27  7:22       ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828003903.GB15462@richard \
    --to=richardw.yang@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alastair@au1.ibm.com \
    --cc=alastair@d-silva.org \
    --cc=cai@lca.pw \
    --cc=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox