From: Michal Hocko <mhocko@kernel.org>
To: Hillf Danton <hdanton@sina.com>
Cc: Yafang Shao <laoar.shao@gmail.com>,
Adric Blake <promarbler14@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Mel Gorman <mgorman@techsingularity.net>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: WARNINGs in set_task_reclaim_state with memory cgroupandfullmemory usage
Date: Tue, 27 Aug 2019 15:53:22 +0200 [thread overview]
Message-ID: <20190827135322.GG7538@dhcp22.suse.cz> (raw)
In-Reply-To: <20190827132931.848986B0008@kanga.kvack.org>
On Tue 27-08-19 21:29:24, Hillf Danton wrote:
>
> >> No preference seems in either way except for retaining
> >> nr_to_reclaim == SWAP_CLUSTER_MAX and target_mem_cgroup == memcg.
> >
> > Setting target_mem_cgroup here may be a very subtle change for
> > subsequent processing.
> > Regarding retraining nr_to_reclaim == SWAP_CLUSTER_MAX, it may not
> > proper for direct reclaim, that may cause some stall if we iterate all
> > memcgs here.
>
> Mind posting a RFC to collect thoughts?
I hope I have explained why this is not desirable
http://lkml.kernel.org/r/20190827120335.GA7538@dhcp22.suse.cz
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2019-08-27 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 13:05 WARNINGs in set_task_reclaim_state with memory cgroup andfullmemory usage Hillf Danton
2019-08-27 11:51 ` Yafang Shao
2019-08-27 13:29 ` WARNINGs in set_task_reclaim_state with memory cgroupandfullmemory usage Hillf Danton
2019-08-27 13:53 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827135322.GG7538@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=ktkhai@virtuozzo.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=promarbler14@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox