From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F226C3A5A3 for ; Tue, 27 Aug 2019 13:29:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3986820673 for ; Tue, 27 Aug 2019 13:29:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3986820673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B96A16B0008; Tue, 27 Aug 2019 09:29:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B46F86B000A; Tue, 27 Aug 2019 09:29:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A36646B000C; Tue, 27 Aug 2019 09:29:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 848986B0008 for ; Tue, 27 Aug 2019 09:29:31 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 17D8162D9 for ; Tue, 27 Aug 2019 13:29:31 +0000 (UTC) X-FDA: 75868289742.23.light11_52e11b06f1232 X-HE-Tag: light11_52e11b06f1232 X-Filterd-Recvd-Size: 4966 Received: from mail3-166.sinamail.sina.com.cn (mail3-166.sinamail.sina.com.cn [202.108.3.166]) by imf27.hostedemail.com (Postfix) with SMTP for ; Tue, 27 Aug 2019 13:29:29 +0000 (UTC) Received: from unknown (HELO [IPv6:::ffff:192.168.199.155])([114.254.173.51]) by sina.com with ESMTP id 5D6530330002EA88; Tue, 27 Aug 2019 21:29:26 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 14190454982534 MIME-Version: 1.0 To: Yafang Shao Cc: Adric Blake , Andrew Morton , Kirill Tkhai , Johannes Weiner , Michal Hocko , Daniel Jordan , Yang Shi , Mel Gorman , Linux MM , LKML From: Hillf Danton Subject: Re: WARNINGs in set_task_reclaim_state with memory cgroupandfullmemory usage Date: Tue, 27 Aug 2019 21:29:24 +0800 Importance: normal X-Priority: 3 In-Reply-To: References: <20190824130516.2540-1-hdanton@sina.com> Content-Type: multipart/alternative; boundary="_C8E0572E-CB3B-4C3E-82BC-F8B8094DD781_" Message-Id: <20190827132931.848986B0008@kanga.kvack.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --_C8E0572E-CB3B-4C3E-82BC-F8B8094DD781_ Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" >> No preference seems in either way except for retaining >> nr_to_reclaim =3D=3D SWAP_CLUSTER_MAX and target_mem_cgroup =3D=3D memcg= . > > Setting target_mem_cgroup here may be a very subtle change for > subsequent processing. > Regarding retraining nr_to_reclaim =3D=3D SWAP_CLUSTER_MAX, it may not > proper for direct reclaim, that may cause some stall if we iterate all > memcgs here. Mind posting a RFC to collect thoughts? --_C8E0572E-CB3B-4C3E-82BC-F8B8094DD781_ Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"

 =

>> No preference s= eems in either way except for retaining

>> nr_to_reclaim =3D=3D SWAP_CLUSTER_MAX and target_me= m_cgroup =3D=3D memcg.

&g= t; 

> = Setting=C2=A0 target_mem_cgroup here may be a very subtle change for=

> subsequent processing.

> Regarding retraining nr= _to_reclaim =3D=3D SWAP_CLUSTER_MAX, it may not

> proper for direct reclaim, that may cause some = stall if we iterate all

&= gt; memcgs here.

&nb= sp;

Mind posting a = RFC to collect thoughts?

 

= --_C8E0572E-CB3B-4C3E-82BC-F8B8094DD781_--